Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume core updates: Popover #9862

Closed
Tracked by #9860
tlabaj opened this issue Dec 6, 2023 · 3 comments
Closed
Tracked by #9860

Consume core updates: Popover #9862

tlabaj opened this issue Dec 6, 2023 · 3 comments
Assignees
@thatblindgeye
Milestone
2023.Q4

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Dec 6, 2023

No description provided.

@tlabaj tlabaj mentioned this issue Dec 6, 2023
Closed
@tlabaj tlabaj added PF6 labels Dec 6, 2023
@tlabaj tlabaj added this to the 2023.Q4 milestone Dec 6, 2023
@thatblindgeye
Copy link
Contributor

Doesn't look like any updates needed. React's Popover uses the maxwidth and minwidth var values, but neither of those were touched in Core. cc @mcoker @andrew-ronaldson @lboehling for confirmation that the following screenshots of React v6 popover from alpha 34 release looks good compared to core v6 popover; I can also do a side by side comparison during a happy hour if it's easier

Basic v6 React Popover

v6 React Popover without padding

v6 React Popover aligned at bottom start

v6 React Popover with danger icon

@andrew-ronaldson
Copy link
Collaborator

Seems good to me.

@thatblindgeye
Copy link
Contributor

Closing as no updates needed in React (@mcoker left a thumbs up and commented during a Penta meet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
2023.Q4
Development

No branches or pull requests
3 participants
@andrew-ronaldson @tlabaj @thatblindgeye