Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume core Penta updates: Slider #9913

Closed
Tracked by #9911
tlabaj opened this issue Jan 2, 2024 · 3 comments
Closed
Tracked by #9911

Consume core Penta updates: Slider #9913

tlabaj opened this issue Jan 2, 2024 · 3 comments
Assignees

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Jan 2, 2024

Follow up top core PR patternfly/patternfly#6157

@thatblindgeye
Copy link
Contributor

Shouldn't require any updates in React for Slider. There are some things related to the input groups used for examples with a value input, but those issues should be resolved by the Core issue for input group. React components use the __value--c-form-control--width-chars, __value, and __step--Left CSS vars, all of which are still intact in Core.

Some screenshots below of alpha 51 locally compare to the Core v6 staging cc @mcoker @andrew-ronaldson

Discrete slider in dark mode
Discrete slider in light mode

Actions and disabled sliders in dark mode
Actions and disabled sliders in light mode

Following is a slider with RTL enabled to show styling works correctly
Slider in RTL

@srambach
Copy link
Member

Looks good - input group should fix the inputs that don't look quite right. 🎚️

@thatblindgeye
Copy link
Contributor

Closing per comments above + agreement from @andrew-ronaldson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants