Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume core Penta updates: Spinner #9915

Closed
Tracked by #9911
tlabaj opened this issue Jan 2, 2024 · 3 comments
Closed
Tracked by #9911

Consume core Penta updates: Spinner #9915

tlabaj opened this issue Jan 2, 2024 · 3 comments
Assignees
@thatblindgeye
Milestone
Penta alpha release

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Jan 2, 2024 •
edited
Loading

Follow up to core PR patternfly/patternfly#6154
@tlabaj tlabaj mentioned this issue Jan 2, 2024
Closed
@tlabaj tlabaj added PF6 labels Jan 2, 2024
@tlabaj tlabaj added this to the 2024.Q1 milestone Jan 2, 2024
@thatblindgeye thatblindgeye self-assigned this Jan 3, 2024
@thatblindgeye
Copy link
Contributor

thatblindgeye commented Jan 8, 2024 •
edited
Loading

Shouldn't need any updates in React. React is using the diameter CSS var which remains intact in Core, otherwise the React examples match Core examples in terms of visuals and markup. Since the examples show animation it may be easier to show a side by side of alpha 51 locally vs the Core v6 staging via screenshare

Actually comparing React v6 staging to Core v6 staging may suffice

@srambach
Copy link
Member

LGTM 🍭

@thatblindgeye
Copy link
Contributor

Closing per comments above + agreement from @andrew-ronaldson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
Penta alpha release
Development

No branches or pull requests
4 participants
@wise-king-sullyman @srambach @tlabaj @thatblindgeye