Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume core updates: Breadcrumb ( Follow up to issue) #9927

Closed
Tracked by #9413
tlabaj opened this issue Jan 2, 2024 · 4 comments
Closed
Tracked by #9413

Consume core updates: Breadcrumb ( Follow up to issue) #9927

tlabaj opened this issue Jan 2, 2024 · 4 comments
Assignees

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Jan 2, 2024

Follow up to core issue patternfly/patternfly#5731

Also depend on core issue patternfly/patternfly#6162 for menu styling

@tlabaj tlabaj self-assigned this Jan 2, 2024
@tlabaj tlabaj added PF6 labels Jan 2, 2024
@tlabaj tlabaj added this to the 2024.Q1 milestone Jan 2, 2024
@andrew-ronaldson
Copy link
Collaborator

Screenshot 2024-02-20 at 2 36 48 PM
The only thing I noticed was the hover state on this dropdown that doesn't appear in Core. Is that waiting for a menu toggle update? @srambach @mcoker

@srambach
Copy link
Member

Core is still using a dropdown there; patternfly/patternfly#6207 should change that over to a menu-toggle.

@mcoker
Copy link
Contributor

mcoker commented Feb 20, 2024

In chatting with @lboehling about it yesterday, she said that ideally there would be no background color applied to that toggle. We have a button variation that does that, but not a menu toggle variation. For now I was thinking we can just push a CSS update that removes the background for that toggle so no update would need to be made in react. Maybe later we can see if there is a good case for adding that variation as a menu toggle?

@mcoker
Copy link
Contributor

mcoker commented Feb 20, 2024

Breadcrumb lgtm otherwise!

@tlabaj tlabaj closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants