Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon - Add warning for unwrapped icons with props #539

Closed
gitdallas opened this issue Sep 14, 2023 · 1 comment
Closed

Icon - Add warning for unwrapped icons with props #539

gitdallas opened this issue Sep 14, 2023 · 1 comment
Assignees

Comments

@gitdallas
Copy link
Contributor

From chat, Jenny thinks "we should warn on icons that have size, color, or noVerticalAlign set, and state that for changes to size, color, and alignment the recommendation is to wrap with Icon and apply styles via Icon props"

@gitdallas gitdallas self-assigned this Sep 14, 2023
@gitdallas
Copy link
Contributor Author

gitdallas commented Sep 14, 2023

looks like this actually already exists 😆

https://github.com/patternfly/pf-codemods#react-icons-remove-props-5275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant