Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page - Penta updates #543

Closed
thatblindgeye opened this issue Dec 6, 2023 · 0 comments · Fixed by #568
Closed

Page - Penta updates #543

thatblindgeye opened this issue Dec 6, 2023 · 0 comments · Fixed by #568
Assignees
@thatblindgeye
Labels
codemod PF6
Milestone
Penta alpha release

Comments

@thatblindgeye
Copy link
Collaborator

thatblindgeye commented Dec 6, 2023 •
edited
Loading

Follow up to breaking change PR patternfly/patternfly-react#9848 and patternfly/patternfly-react#9774

Added a new option to the variant prop, and updated so the class from the variant prop will only be applied when type="default" (previously a class would always be applied)

PageSidebar: Removed Page sidebar theme prop since it only supports the default theme.
PageSection: Removed light, dark and `darker variant since the are no longer supported.
PageHeader (deprecated): removed isSelected prop since it is no longer supported in Page

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
codemod PF6
Projects
PatternFly Issues
Archived in project
Milestone
Penta alpha release
Development

Successfully merging a pull request may close this issue.

chore(Page): updated props @thatblindgeye thatblindgeye/pf-codemods
3 participants
@wise-king-sullyman @tlabaj @thatblindgeye