Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion - Penta updates #545

Closed
thatblindgeye opened this issue Dec 18, 2023 · 0 comments · Fixed by #569
Closed

Accordion - Penta updates #545

thatblindgeye opened this issue Dec 18, 2023 · 0 comments · Fixed by #569
Assignees
@thatblindgeye
Labels
PF6
Milestone
Penta alpha release

Comments

@thatblindgeye
Copy link
Collaborator

Follow up to breaking change PR patternfly/patternfly-react#9876

  • AccordionContent had the isHidden prop removed (the hidden attr will be set automatically by AccordionItem's isExpanded
  • AccordionToggle had the isExpanded prop removed, as this prop should be passed to AccordionItem instead
  • AccordionItem has a markup change and now renders a div element (previously rendered a React fragment)

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
PF6
Projects
PatternFly Issues
Archived in project
Milestone
Penta alpha release
Development

Successfully merging a pull request may close this issue.

feat(Accordion): updates props thatblindgeye/pf-codemods
3 participants
@wise-king-sullyman @srambach @thatblindgeye