Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HelperText - Penta updates #552

Closed
thatblindgeye opened this issue Jan 22, 2024 · 0 comments · Fixed by #572
Closed

HelperText - Penta updates #552

thatblindgeye opened this issue Jan 22, 2024 · 0 comments · Fixed by #572
Assignees
@thatblindgeye
Labels
codemod
Milestone
Penta alpha release

Comments

@thatblindgeye
Copy link
Collaborator

Follow up to breaking change PR:

  • feat(HelperText): consumed Penta updates patternfly-react#10029
    • removed hasIcon prop; icons will render automatically when variant !== "default", or when icon is passed
    • removed isDynamic prop; this no longer serves any purpose
    • the screenReaderText prop is now based on the variant prop not being "default" (previously was based on the isDynamic prop being true)

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
codemod
Projects
PatternFly Issues
Archived in project
Milestone
Penta alpha release
Development

Successfully merging a pull request may close this issue.

feat(HelperTextItem): added rule for prop removals and updates thatblindgeye/pf-codemods
2 participants
@tlabaj @thatblindgeye