Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login - LoginMainFooterLinksItem structure update #598

Closed
Tracked by #176
kmcfaul opened this issue Feb 28, 2024 · 0 comments · Fixed by #608
Closed
Tracked by #176

Login - LoginMainFooterLinksItem structure update #598

kmcfaul opened this issue Feb 28, 2024 · 0 comments · Fixed by #608
Assignees
Labels

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Feb 28, 2024

Follow up to patternfly/patternfly-react#10107

Instead of passing properties to the component, the content will be passed directly via children. There should be enough info from the props to generate the children (if the component was "a" create a link or if it was a "button" use our plain variant Button) but I'm wondering if that is still making too many assumptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants