Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: moveSpecifiers helper applies to all specifiers #605

Closed
adamviktora opened this issue Mar 7, 2024 · 0 comments · Fixed by #606
Closed

Bug: moveSpecifiers helper applies to all specifiers #605

adamviktora opened this issue Mar 7, 2024 · 0 comments · Fixed by #606
Assignees
Labels

Comments

@adamviktora
Copy link
Contributor

The moveSpecifiers helper should include only specifiers which are being passed to it in the first argument specifiersToMove. Internally it calls getFromPackage and passes it the specifiersToMove as a 3rd argument. But since getFromPackage has been refactored and only uses 2 arguments, the filtering does not work and moveSpecifiers will be applied on any specifier.

We use moveSpecifiers helper in the chip-deprecated rule, which is causing unwanted errors on every component imported from patternfly package.

Screenshot 2024-03-07 at 17 47 53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants