Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alignEnd - running codemods for v6 produces error for using alignEnd #646

Closed
jessiehuff opened this issue May 22, 2024 · 1 comment
Closed
Labels

Comments

@jessiehuff
Copy link
Contributor

When running the v6 codemods on Quick Starts, I noticed that it updated alignRight to alignEnd but gave the following error:
[!] (plugin rpt2) Error: /Users/jhuff/patternfly-quickstarts/packages/module/src/catalog/Toolbar/QuickStartCatalogFilterItems.tsx(76,16): semantic error TS2322: Type '"alignEnd"' is not assignable to type '"alignRight" | "alignLeft"'.

I had to revert it back to using alignRight for now.

@thatblindgeye
Copy link
Collaborator

Retested running the v6 codemods on quick starts using the latest v6 alphas. I no longer get the error mentioned above after running codemod fixes and yarn build. The only error I get is [!] (plugin rpt2) Error: /Users/eolkowsk/GitHub/PatternFly/patternfly-quickstarts/packages/module/src/QuickStartCatalogPage.tsx(7,3): semantic error TS2305: Module '"@patternfly/react-core"' has no exported member 'Content'. which should be expected until all applicable PRs for updating Text/TextContent to just Content are merged in all repos.

Will close this for now, but if anyone else notices the original issue mentioned in the original post we can reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants