Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page - updated logic for rendering PageMainBody #674

Closed
thatblindgeye opened this issue Jun 25, 2024 · 0 comments · Fixed by #699
Closed

Page - updated logic for rendering PageMainBody #674

thatblindgeye opened this issue Jun 25, 2024 · 0 comments · Fixed by #699
Assignees

Comments

@thatblindgeye
Copy link
Collaborator

thatblindgeye commented Jun 25, 2024

Follow up to breaking change PR patternfly/patternfly-react#10650

Previously isWidthLimited prop controlled whether children passed to certain Page components woudl be wrapped in a __main-body element. That is no longer the case. We should probably just provide a warning for that + mentioning we have a new hasMainBodyWrapper prop to control this wrapper element (though intended for when multiple PageMainBody's are desired).

We've also removed the PageNavigation component and the "nav" PageSection typing.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant