Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log viewer - add css import / warning about needing to add it #676

Closed
wise-king-sullyman opened this issue Jun 26, 2024 · 0 comments · Fixed by #690
Closed

Log viewer - add css import / warning about needing to add it #676

wise-king-sullyman opened this issue Jun 26, 2024 · 0 comments · Fixed by #690
Assignees
Labels

Comments

@wise-king-sullyman
Copy link
Collaborator

wise-king-sullyman commented Jun 26, 2024

Follow up to breaking change PR patternfly/patternfly#6831

After the above PR consumers will need to import the log viewer stylesheet separately and from log viewer itself as it will no longer be bundled with patternfly/patternfly.

If we can think of a way to do it we should automatically add that import for them, but if that might not be possible in all cases we should at the least identify if a consumer is using log viewer and warn them that they'll need to manually add that import to whereever they import their styles.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants