Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmptyState fixer doesn't seem to handle conditionally rendered EmptyStateIcon components #792

Open
wise-king-sullyman opened this issue Oct 22, 2024 · 0 comments
Open

EmptyState fixer doesn't seem to handle conditionally rendered EmptyStateIcon components #792

wise-king-sullyman opened this issue Oct 22, 2024 · 0 comments
Labels
PF Team

Comments

@wise-king-sullyman
Copy link
Collaborator

Src:
Image

After the current codemods run:
Image

It should be ideally moving that logic into the icon prop of the EmptyState.

This issue was encountered in https://gitlab.cee.redhat.com/service/uhc-portal (requires RH VPN)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PF Team
Projects
PatternFly Issues
Status: Needs triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wise-king-sullyman