feat(Avatar) replace border with isBordered #571
Merged
+72
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dominik-Petrik
requested review from
wise-king-sullyman,
mfrances17 and
thatblindgeye
There was a problem hiding this comment.
Code looks good (missing blank lines at the end of the files so I'm guessing you might want to run prettier on all of them, that's not blocking though).
One big question though: do you know what the deal is with all the yarn.lock changes? Seems odd when there is no package file change here.
|
Hmm, let me investigate that |
Dominik-Petrik
force-pushed
the
avatar-penta-updates
branch
2 times, most recently
from
7a09cb5
to
7b1b30b
Compare
...demods/src/rules/v6/avatarReplaceBorderForIsBordered/avatar-replace-border-for-isBordered.md
Outdated
Show resolved
Hide resolved
...demods/src/rules/v6/avatarReplaceBorderForIsBordered/avatar-replace-border-for-isBordered.md
Outdated
Show resolved
Hide resolved
...demods/src/rules/v6/avatarReplaceBorderForIsBordered/avatar-replace-border-for-isBordered.ts
Show resolved
Hide resolved
Dominik-Petrik
force-pushed
the
avatar-penta-updates
branch
2 times, most recently
from
8d0f1c8
to
abef321
Compare
thatblindgeye
approved these changes
Feb 28, 2024
Dominik-Petrik
force-pushed
the
avatar-penta-updates
branch
from
abef321
to
5683868
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #549