Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync main with latest fixes in the v5 branch #251

Closed
jenny-s51 opened this issue Nov 13, 2024 · 2 comments · Fixed by #262
Closed

Sync main with latest fixes in the v5 branch #251

jenny-s51 opened this issue Nov 13, 2024 · 2 comments · Fixed by #262
Assignees
@jenny-s51
Labels
needs design

Comments

@jenny-s51
Copy link
Collaborator

jenny-s51 commented Nov 13, 2024 •
edited
Loading

Apply all changes from:

cc @nicolethoen @dlabaj
@jenny-s51 jenny-s51 self-assigned this Nov 13, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Nov 13, 2024
@jeff-phillips-18
Copy link
Member

@andrew-ronaldson will need to provide the v6 tokens for the selection area for #248

@jeff-phillips-18
Copy link
Member

jeff-phillips-18 commented Dec 3, 2024 •
edited
Loading

For v6, we want the selection area to be:
fill: --pf-t--global--border--color--clicked at 30%
stroke: --pf-t--global--color--brand--clicked

We do a 1px dashed line on drag areas if possible. If not solid is fine

@jenny-s51 jenny-s51 mentioned this issue Dec 4, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Issues Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenny-s51 jenny-s51

Labels
needs design
Projects
PatternFly Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(update): cherry pick missing v5 updates onto main jenny-s51/react-topology
2 participants
@jeff-phillips-18 @jenny-s51