Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access control applied to incorrect fields #10720

Closed
LimChorngUan opened this issue Jan 22, 2025 · 0 comments · Fixed by #10729
Closed

Access control applied to incorrect fields #10720

LimChorngUan opened this issue Jan 22, 2025 · 0 comments · Fixed by #10729
Labels
created-by: Contributor prioritized

Comments

@LimChorngUan
Copy link
Contributor

Describe the Bug

Access control is being applied to the wrong fields, causing those fields to not appear in the UI.
This issue has been observed specifically with array fields inside tabs.

Link to the code that reproduces this issue

LimChorngUan/payload-bug-reproduction@024a006

Reproduction Steps

  1. Open the "Post" collection.
  2. Locate the second field, which has an access control configuration.
  3. Add a new link in "Tab1" or "Tab2".
  4. Observe that within the link field, no fields are shown.

Actual
Image

Expected
Image

Which area(s) are affected? (Select all that apply)

area: core, area: ui

Environment Info

v3.18.0
@LimChorngUan LimChorngUan added status: needs-triage Possible bug which hasn't been reproduced yet validate-reproduction labels Jan 22, 2025
@akhrarovsaid akhrarovsaid mentioned this issue Jan 22, 2025
Merged
JarrodMFlesch added a commit that referenced this issue Jan 27, 2025
@akhrarovsaid @JarrodMFlesch
fix(ui): include check for parent permissions in renderField (#10729)
8289588 
### What?
This PR fixes an issue for tab subfield permissions

### Why?
Permissions were not being correctly extracted when passing them down.

### How?
Properly extracts permissions when rendering fields inside the active tab.

Fixes #10720

---------

Co-authored-by: Jarrod Flesch <[email protected]>
@github-actions github-actions bot removed the status: needs-triage Possible bug which hasn't been reproduced yet label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
created-by: Contributor prioritized
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): include check for parent permissions in renderField akhrarovsaid/payload
2 participants
@JarrodMFlesch @LimChorngUan