Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curie lists have random order as they are constructed as set() internally. #28

Open
mikenotfound opened this issue Mar 16, 2021 · 0 comments

Comments

@mikenotfound
Copy link

mikenotfound commented Mar 16, 2021

Looking through the code it appears curies are initially constructed as a set() but subsequently converted to a plain list(). Therefore the order of curies is randomised.

This not only seems at odds with the expected behaviour of a list (or list-like) structure, but means tests become more complex --- having to convert the actual, and expected output to compare curies as sets is painful.

Perhaps this is more of an edge case, but would the developers be willing to discuss this possibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant