Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paymill\Models\Request\Transaction.php duplicated code #148

Open
BogMor opened this issue Mar 5, 2019 · 0 comments
Open

Paymill\Models\Request\Transaction.php duplicated code #148

BogMor opened this issue Mar 5, 2019 · 0 comments

Comments

@BogMor
Copy link

BogMor commented Mar 5, 2019 •
edited
Loading

Hello
In the file Paymill\Models\Request\Transaction.php at the line 607 is a duplicated code for getShippingAddress and getBillingAddress. Is similar with line 589 and 592.

            if(!is_null($this->getShippingAddress())) {
@BogMor BogMor changed the title Paymill\Models\Request\Transaction.php doubled code Paymill\Models\Request\Transaction.php duplicated code Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BogMor