Can only register models that have a primary key named "id"

[smgeorge99]

Does any model registered for inclusion in the generated seeds file have to have a primary key named "id"? I was wondering if there was a way to configure the name of the PK for each model registered in the seed_migration.rb initializer. Or would this be a new feature that needed to be developed?

[pjambet]

We indeed built it assuming that pks are name id. It could be interesting to add a config option to allow other names, with a default value of id, to keep everything backward compatible.

I won't have time to work on this in the next days/weeks, but I'd be happy to accept a Pull Request with those changes if you want to work on it.

Let me know if you have any questions.

[rubyrider]

I would suggest to add more dynamic stuffs, instead of lots of hardcoding, proxy method modules can come forward to sole those. And registry entry should contain more configuration options. There are also no options to handle different different table types other then primary tables. Example, a table without id or secondary table a joining tables etc. I have a plan to make a pull request tonight to solve this issue with more options to handle exceptional cases.

[pjambet]

@rubyrider Thanks for your suggestions. Is that something that you've been working on? As mentioned in my first comment, I won't have time to work on this, but I would be happy to accept a PR solving this issue.

[rubyrider]

@pjambet if you want I can create a pr! I have solved this issue a long ago using a patch on that time.

[pjambet]

Definitely! I would love to have a feature like that merged upstream.

Sorry again for not replying earlier.

[rubyrider]

its okey! :) I will send pr as soon as I get free time!

On Tue, Dec 1, 2015 at 12:16 AM, Pierre [email protected] wrote:

Definitely! I would love to have a feature like that merged upstream.

Sorry again for not replying earlier.

—
Reply to this email directly or view it on GitHub
#23 (comment)
.

Regards,
Irfan Ahmed Rizvi,
Freelancer- Senior Ruby on Rails Developer
https://www.odesk.com/users/~01c44db951895e4589
m: +880 1766 67 81 30
e: [email protected]

[pjambet]

@rubyrider Awesome, thanks!

[rubyrider]

okey, I will do!

[jfoo1984]

#80 might partially address this issue, as it doesn't require an id field on models