From 971526855e2cfa26c1f494b1c12d2bf1014fc237 Mon Sep 17 00:00:00 2001 From: Paul Colby Date: Fri, 14 Oct 2016 17:49:41 +1100 Subject: [PATCH] Use metres-per-second for TCX speeds #74 The Polar speed data in in kilometres-per-hour, but TCX uses metres-per- second (apparently; the relevant schemas are not explicit about it). For completeness, the HRM output is already using the correct units (that is, kilometres-per-hour multiplied by 10 or 128 depending on the situation), and the GPX output does not include speed data at all. So neither of those formats needing correcting. --- src/polar/v2/trainingsession.cpp | 4 +-- ...ining-sessions-19401412.all-extensions.tcx | 20 +++++------ ...ning-sessions-19401412.garmin-activity.tcx | 20 +++++------ ...aining-sessions-19401412.garmin-course.tcx | 10 +++--- .../testdata/training-sessions-19401412.tcx | 10 +++--- .../training-sessions-19401412.utc.tcx | 10 +++--- ...ining-sessions-19946380.all-extensions.tcx | 4 +-- ...ning-sessions-19946380.garmin-activity.tcx | 4 +-- ...aining-sessions-19946380.garmin-course.tcx | 2 +- .../testdata/training-sessions-19946380.tcx | 2 +- .../training-sessions-19946380.utc.tcx | 2 +- ...ining-sessions-22165267.all-extensions.tcx | 36 +++++++++---------- ...ning-sessions-22165267.garmin-activity.tcx | 36 +++++++++---------- ...aining-sessions-22165267.garmin-course.tcx | 18 +++++----- .../testdata/training-sessions-22165267.tcx | 18 +++++----- .../training-sessions-22165267.utc.tcx | 18 +++++----- ...ning-sessions-267510822.all-extensions.tcx | 4 +-- ...ing-sessions-267510822.garmin-activity.tcx | 4 +-- ...ining-sessions-267510822.garmin-course.tcx | 2 +- .../testdata/training-sessions-267510822.tcx | 2 +- .../training-sessions-267510822.utc.tcx | 2 +- 21 files changed, 114 insertions(+), 114 deletions(-) diff --git a/src/polar/v2/trainingsession.cpp b/src/polar/v2/trainingsession.cpp index 5826a58a..b02d78a6 100644 --- a/src/polar/v2/trainingsession.cpp +++ b/src/polar/v2/trainingsession.cpp @@ -2189,7 +2189,7 @@ QDomDocument TrainingSession::toTCX(const QString &buildTime) const lx.appendChild(doc.createElement(QLatin1String("AvgSpeed"))) .appendChild(doc.createTextNode(QString::fromLatin1("%1") .arg(first(firstMap(stats.value(QLatin1String("speed"))) - .value(QLatin1String("average"))).toDouble()))); + .value(QLatin1String("average"))).toDouble() / 3.6))); } if (stats.contains(QLatin1String("cadence"))) { @@ -2435,7 +2435,7 @@ void TrainingSession::addLapStats(QDomDocument &doc, QDomElement &lap, lap.appendChild(doc.createElement(QLatin1String("MaximumSpeed"))) .appendChild(doc.createTextNode(QString::fromLatin1("%1") .arg(first(firstMap(stats.value(QLatin1String("speed"))) - .value(QLatin1String("maximum"))).toDouble()))); + .value(QLatin1String("maximum"))).toDouble() / 3.6))); } // Calories is only available per exercise, not per lap, but it is required diff --git a/test/polar/v2/testdata/training-sessions-19401412.all-extensions.tcx b/test/polar/v2/testdata/training-sessions-19401412.all-extensions.tcx index 45985947..0106ebcd 100644 --- a/test/polar/v2/testdata/training-sessions-19401412.all-extensions.tcx +++ b/test/polar/v2/testdata/training-sessions-19401412.all-extensions.tcx @@ -6,7 +6,7 @@ 1803.88 2941.6 - 13.896 + 3.86 0 153 @@ -27080,7 +27080,7 @@ - 5.87056 + 1.63071 @@ -27088,7 +27088,7 @@ 1492.25 2033.9 - 10.476 + 2.91 0 165 @@ -49497,7 +49497,7 @@ - 4.90671 + 1.36298 @@ -49505,7 +49505,7 @@ 227.5 529.7 - 9.684 + 2.69 0 144 @@ -52924,7 +52924,7 @@ - 8.38207 + 2.32835 @@ -52932,7 +52932,7 @@ 1561.62 2594.9 - 12.888 + 3.58 0 172 @@ -76376,7 +76376,7 @@ - 5.982 + 1.66167 @@ -76384,7 +76384,7 @@ 153.5 383.8 - 11.088 + 3.08 0 158 @@ -78693,7 +78693,7 @@ - 9.00117 + 2.50033 diff --git a/test/polar/v2/testdata/training-sessions-19401412.garmin-activity.tcx b/test/polar/v2/testdata/training-sessions-19401412.garmin-activity.tcx index ba756295..c0e6f13a 100644 --- a/test/polar/v2/testdata/training-sessions-19401412.garmin-activity.tcx +++ b/test/polar/v2/testdata/training-sessions-19401412.garmin-activity.tcx @@ -6,7 +6,7 @@ 1803.88 2941.6 - 13.896 + 3.86 0 153 @@ -27080,14 +27080,14 @@ - 5.87056 + 1.63071 1492.25 2033.9 - 10.476 + 2.91 0 165 @@ -49496,14 +49496,14 @@ - 4.90671 + 1.36298 227.5 529.7 - 9.684 + 2.69 0 144 @@ -52922,14 +52922,14 @@ - 8.38207 + 2.32835 1561.62 2594.9 - 12.888 + 3.58 0 172 @@ -76373,14 +76373,14 @@ - 5.982 + 1.66167 153.5 383.8 - 11.088 + 3.08 0 158 @@ -78689,7 +78689,7 @@ - 9.00117 + 2.50033 diff --git a/test/polar/v2/testdata/training-sessions-19401412.garmin-course.tcx b/test/polar/v2/testdata/training-sessions-19401412.garmin-course.tcx index 95283667..912f4931 100644 --- a/test/polar/v2/testdata/training-sessions-19401412.garmin-course.tcx +++ b/test/polar/v2/testdata/training-sessions-19401412.garmin-course.tcx @@ -6,7 +6,7 @@ 1803.88 2941.6 - 13.896 + 3.86 0 153 @@ -21671,7 +21671,7 @@ 1492.25 2033.9 - 10.476 + 2.91 0 165 @@ -39604,7 +39604,7 @@ 227.5 529.7 - 9.684 + 2.69 0 144 @@ -42345,7 +42345,7 @@ 1561.62 2594.9 - 12.888 + 3.58 0 172 @@ -61106,7 +61106,7 @@ 153.5 383.8 - 11.088 + 3.08 0 158 diff --git a/test/polar/v2/testdata/training-sessions-19401412.tcx b/test/polar/v2/testdata/training-sessions-19401412.tcx index 4eb6c49c..5dad7bfa 100644 --- a/test/polar/v2/testdata/training-sessions-19401412.tcx +++ b/test/polar/v2/testdata/training-sessions-19401412.tcx @@ -6,7 +6,7 @@ 1803.875 2941.6 - 13.896 + 3.86 0 153 @@ -21670,7 +21670,7 @@ 1492.25 2033.9 - 10.476 + 2.91 0 165 @@ -39602,7 +39602,7 @@ 227.5 529.7 - 9.684 + 2.69 0 144 @@ -42342,7 +42342,7 @@ 1561.625 2594.9 - 12.888 + 3.58 0 172 @@ -61102,7 +61102,7 @@ 153.5 383.8 - 11.088 + 3.08 0 158 diff --git a/test/polar/v2/testdata/training-sessions-19401412.utc.tcx b/test/polar/v2/testdata/training-sessions-19401412.utc.tcx index 724b972a..7eb732de 100644 --- a/test/polar/v2/testdata/training-sessions-19401412.utc.tcx +++ b/test/polar/v2/testdata/training-sessions-19401412.utc.tcx @@ -6,7 +6,7 @@ 1803.88 2941.6 - 13.896 + 3.86 0 153 @@ -21670,7 +21670,7 @@ 1492.25 2033.9 - 10.476 + 2.91 0 165 @@ -39602,7 +39602,7 @@ 227.5 529.7 - 9.684 + 2.69 0 144 @@ -42342,7 +42342,7 @@ 1561.62 2594.9 - 12.888 + 3.58 0 172 @@ -61102,7 +61102,7 @@ 153.5 383.8 - 11.088 + 3.08 0 158 diff --git a/test/polar/v2/testdata/training-sessions-19946380.all-extensions.tcx b/test/polar/v2/testdata/training-sessions-19946380.all-extensions.tcx index ac0abcfc..20c257c9 100644 --- a/test/polar/v2/testdata/training-sessions-19946380.all-extensions.tcx +++ b/test/polar/v2/testdata/training-sessions-19946380.all-extensions.tcx @@ -6,7 +6,7 @@ 3900.25 4571.6 - 8.388 + 2.33 537 119 @@ -58313,7 +58313,7 @@ - 4.21967 + 1.17213 diff --git a/test/polar/v2/testdata/training-sessions-19946380.garmin-activity.tcx b/test/polar/v2/testdata/training-sessions-19946380.garmin-activity.tcx index ce917f54..c9970f10 100644 --- a/test/polar/v2/testdata/training-sessions-19946380.garmin-activity.tcx +++ b/test/polar/v2/testdata/training-sessions-19946380.garmin-activity.tcx @@ -6,7 +6,7 @@ 3900.25 4571.6 - 8.388 + 2.33 537 119 @@ -58313,7 +58313,7 @@ - 4.21967 + 1.17213 diff --git a/test/polar/v2/testdata/training-sessions-19946380.garmin-course.tcx b/test/polar/v2/testdata/training-sessions-19946380.garmin-course.tcx index 3aa541d0..2258c686 100644 --- a/test/polar/v2/testdata/training-sessions-19946380.garmin-course.tcx +++ b/test/polar/v2/testdata/training-sessions-19946380.garmin-course.tcx @@ -6,7 +6,7 @@ 3900.25 4571.6 - 8.388 + 2.33 537 119 diff --git a/test/polar/v2/testdata/training-sessions-19946380.tcx b/test/polar/v2/testdata/training-sessions-19946380.tcx index f8bfac1b..1997ff7f 100644 --- a/test/polar/v2/testdata/training-sessions-19946380.tcx +++ b/test/polar/v2/testdata/training-sessions-19946380.tcx @@ -6,7 +6,7 @@ 3900.25 4571.6 - 8.388 + 2.33 537 119 diff --git a/test/polar/v2/testdata/training-sessions-19946380.utc.tcx b/test/polar/v2/testdata/training-sessions-19946380.utc.tcx index e481cb91..c57d5fd0 100644 --- a/test/polar/v2/testdata/training-sessions-19946380.utc.tcx +++ b/test/polar/v2/testdata/training-sessions-19946380.utc.tcx @@ -6,7 +6,7 @@ 3900.25 4571.6 - 8.388 + 2.33 537 119 diff --git a/test/polar/v2/testdata/training-sessions-22165267.all-extensions.tcx b/test/polar/v2/testdata/training-sessions-22165267.all-extensions.tcx index 127a7ec5..aa4fbd6d 100644 --- a/test/polar/v2/testdata/training-sessions-22165267.all-extensions.tcx +++ b/test/polar/v2/testdata/training-sessions-22165267.all-extensions.tcx @@ -6,7 +6,7 @@ 238.5 664 - 11.3721 + 3.15893 0 153 @@ -4561,7 +4561,7 @@ - 10.0226 + 2.78407 80 84 @@ -4571,7 +4571,7 @@ 242 662 - 10.6787 + 2.96631 0 160 @@ -9184,7 +9184,7 @@ - 9.84793 + 2.73554 83 85 @@ -9194,7 +9194,7 @@ 237.5 665.2 - 11.1641 + 3.10114 0 166 @@ -13731,7 +13731,7 @@ - 10.083 + 2.80084 83 86 @@ -13741,7 +13741,7 @@ 175 662.1 - 14.1458 + 3.9294 0 184 @@ -17081,7 +17081,7 @@ - 13.6203 + 3.78343 85 89 @@ -17091,7 +17091,7 @@ 264.5 668 - 13.8685 + 3.85235 0 169 @@ -22122,7 +22122,7 @@ - 9.09187 + 2.52552 81 84 @@ -22132,7 +22132,7 @@ 257.5 659.2 - 10.1933 + 2.83148 0 165 @@ -27049,7 +27049,7 @@ - 9.216 + 2.56 82 85 @@ -27059,7 +27059,7 @@ 186 673.6 - 13.6604 + 3.79456 0 182 @@ -30608,7 +30608,7 @@ - 13.0374 + 3.62151 84 86 @@ -30618,7 +30618,7 @@ 269.5 670.6 - 13.175 + 3.65973 0 167 @@ -35744,7 +35744,7 @@ - 8.95792 + 2.48831 81 83 @@ -35754,7 +35754,7 @@ 234.5 676 - 11.6495 + 3.23597 0 169 @@ -40234,7 +40234,7 @@ - 10.3778 + 2.88273 81 84 diff --git a/test/polar/v2/testdata/training-sessions-22165267.garmin-activity.tcx b/test/polar/v2/testdata/training-sessions-22165267.garmin-activity.tcx index db35c6ca..c9f649ba 100644 --- a/test/polar/v2/testdata/training-sessions-22165267.garmin-activity.tcx +++ b/test/polar/v2/testdata/training-sessions-22165267.garmin-activity.tcx @@ -6,7 +6,7 @@ 238.5 664 - 11.3721 + 3.15893 0 153 @@ -4561,7 +4561,7 @@ - 10.0226 + 2.78407 80 84 @@ -4570,7 +4570,7 @@ 242 662 - 10.6787 + 2.96631 0 160 @@ -9183,7 +9183,7 @@ - 9.84793 + 2.73554 83 85 @@ -9192,7 +9192,7 @@ 237.5 665.2 - 11.1641 + 3.10114 0 166 @@ -13729,7 +13729,7 @@ - 10.083 + 2.80084 83 86 @@ -13738,7 +13738,7 @@ 175 662.1 - 14.1458 + 3.9294 0 184 @@ -17078,7 +17078,7 @@ - 13.6203 + 3.78343 85 89 @@ -17087,7 +17087,7 @@ 264.5 668 - 13.8685 + 3.85235 0 169 @@ -22118,7 +22118,7 @@ - 9.09187 + 2.52552 81 84 @@ -22127,7 +22127,7 @@ 257.5 659.2 - 10.1933 + 2.83148 0 165 @@ -27044,7 +27044,7 @@ - 9.216 + 2.56 82 85 @@ -27053,7 +27053,7 @@ 186 673.6 - 13.6604 + 3.79456 0 182 @@ -30602,7 +30602,7 @@ - 13.0374 + 3.62151 84 86 @@ -30611,7 +30611,7 @@ 269.5 670.6 - 13.175 + 3.65973 0 167 @@ -35737,7 +35737,7 @@ - 8.95792 + 2.48831 81 83 @@ -35746,7 +35746,7 @@ 234.5 676 - 11.6495 + 3.23597 0 169 @@ -40226,7 +40226,7 @@ - 10.3778 + 2.88273 81 84 diff --git a/test/polar/v2/testdata/training-sessions-22165267.garmin-course.tcx b/test/polar/v2/testdata/training-sessions-22165267.garmin-course.tcx index 81ac6ab6..685b355f 100644 --- a/test/polar/v2/testdata/training-sessions-22165267.garmin-course.tcx +++ b/test/polar/v2/testdata/training-sessions-22165267.garmin-course.tcx @@ -6,7 +6,7 @@ 238.5 664 - 11.3721 + 3.15893 0 153 @@ -3130,7 +3130,7 @@ 242 662 - 10.6787 + 2.96631 0 160 @@ -6294,7 +6294,7 @@ 237.5 665.2 - 11.1641 + 3.10114 0 166 @@ -9406,7 +9406,7 @@ 175 662.1 - 14.1458 + 3.9294 0 184 @@ -11699,7 +11699,7 @@ 264.5 668 - 13.8685 + 3.85235 0 169 @@ -15149,7 +15149,7 @@ 257.5 659.2 - 10.1933 + 2.83148 0 165 @@ -18521,7 +18521,7 @@ 186 673.6 - 13.6604 + 3.79456 0 182 @@ -20957,7 +20957,7 @@ 269.5 670.6 - 13.175 + 3.65973 0 167 @@ -24472,7 +24472,7 @@ 234.5 676 - 11.6495 + 3.23597 0 169 diff --git a/test/polar/v2/testdata/training-sessions-22165267.tcx b/test/polar/v2/testdata/training-sessions-22165267.tcx index e67af851..b5b2be29 100644 --- a/test/polar/v2/testdata/training-sessions-22165267.tcx +++ b/test/polar/v2/testdata/training-sessions-22165267.tcx @@ -6,7 +6,7 @@ 238.5 664 - 11.3721 + 3.15893 0 153 @@ -3129,7 +3129,7 @@ 242 662 - 10.6787 + 2.96631 0 160 @@ -6292,7 +6292,7 @@ 237.5 665.2 - 11.1641 + 3.10114 0 166 @@ -9403,7 +9403,7 @@ 175 662.1 - 14.1458 + 3.9294 0 184 @@ -11695,7 +11695,7 @@ 264.5 668 - 13.8685 + 3.85235 0 169 @@ -15144,7 +15144,7 @@ 257.5 659.2 - 10.1933 + 2.83148 0 165 @@ -18515,7 +18515,7 @@ 186 673.6 - 13.6604 + 3.79456 0 182 @@ -20950,7 +20950,7 @@ 269.5 670.6 - 13.175 + 3.65973 0 167 @@ -24464,7 +24464,7 @@ 234.5 676 - 11.6495 + 3.23597 0 169 diff --git a/test/polar/v2/testdata/training-sessions-22165267.utc.tcx b/test/polar/v2/testdata/training-sessions-22165267.utc.tcx index 2d7b041c..71fbda3b 100644 --- a/test/polar/v2/testdata/training-sessions-22165267.utc.tcx +++ b/test/polar/v2/testdata/training-sessions-22165267.utc.tcx @@ -6,7 +6,7 @@ 238.5 664 - 11.3721 + 3.15893 0 153 @@ -3129,7 +3129,7 @@ 242 662 - 10.6787 + 2.96631 0 160 @@ -6292,7 +6292,7 @@ 237.5 665.2 - 11.1641 + 3.10114 0 166 @@ -9403,7 +9403,7 @@ 175 662.1 - 14.1458 + 3.9294 0 184 @@ -11695,7 +11695,7 @@ 264.5 668 - 13.8685 + 3.85235 0 169 @@ -15144,7 +15144,7 @@ 257.5 659.2 - 10.1933 + 2.83148 0 165 @@ -18515,7 +18515,7 @@ 186 673.6 - 13.6604 + 3.79456 0 182 @@ -20950,7 +20950,7 @@ 269.5 670.6 - 13.175 + 3.65973 0 167 @@ -24464,7 +24464,7 @@ 234.5 676 - 11.6495 + 3.23597 0 169 diff --git a/test/polar/v2/testdata/training-sessions-267510822.all-extensions.tcx b/test/polar/v2/testdata/training-sessions-267510822.all-extensions.tcx index 011ab1ab..82291851 100644 --- a/test/polar/v2/testdata/training-sessions-267510822.all-extensions.tcx +++ b/test/polar/v2/testdata/training-sessions-267510822.all-extensions.tcx @@ -6,7 +6,7 @@ 6127.25 42809.3 - 60.9 + 16.9167 1638 149 @@ -91934,7 +91934,7 @@ - 25.1521 + 6.98671 114 90 diff --git a/test/polar/v2/testdata/training-sessions-267510822.garmin-activity.tcx b/test/polar/v2/testdata/training-sessions-267510822.garmin-activity.tcx index 05525ecb..2d4ae79d 100644 --- a/test/polar/v2/testdata/training-sessions-267510822.garmin-activity.tcx +++ b/test/polar/v2/testdata/training-sessions-267510822.garmin-activity.tcx @@ -6,7 +6,7 @@ 6127.25 42809.3 - 60.9 + 16.9167 1638 149 @@ -91934,7 +91934,7 @@ - 25.1521 + 6.98671 114 90 diff --git a/test/polar/v2/testdata/training-sessions-267510822.garmin-course.tcx b/test/polar/v2/testdata/training-sessions-267510822.garmin-course.tcx index d9933df4..6220ddeb 100644 --- a/test/polar/v2/testdata/training-sessions-267510822.garmin-course.tcx +++ b/test/polar/v2/testdata/training-sessions-267510822.garmin-course.tcx @@ -6,7 +6,7 @@ 6127.25 42809.3 - 60.9 + 16.9167 1638 149 diff --git a/test/polar/v2/testdata/training-sessions-267510822.tcx b/test/polar/v2/testdata/training-sessions-267510822.tcx index 6cbd2848..1d151ade 100644 --- a/test/polar/v2/testdata/training-sessions-267510822.tcx +++ b/test/polar/v2/testdata/training-sessions-267510822.tcx @@ -6,7 +6,7 @@ 6127.25 42809.3 - 60.9 + 16.9167 1638 149 diff --git a/test/polar/v2/testdata/training-sessions-267510822.utc.tcx b/test/polar/v2/testdata/training-sessions-267510822.utc.tcx index eca1e34a..5f53c114 100644 --- a/test/polar/v2/testdata/training-sessions-267510822.utc.tcx +++ b/test/polar/v2/testdata/training-sessions-267510822.utc.tcx @@ -6,7 +6,7 @@ 6127.25 42809.3 - 60.9 + 16.9167 1638 149