-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test data set with both laps and power #46
Comments
TCX has no support for power data per se, however, both the Garmin Activity Extension (#31) and the Garmin Course Extension (#47) support power data. This change includes power data for both extensions. Note, the Garmin Course Extension is currently not unit tested (will add unit tests shortly). Also, there are a few code paths added in this change that cannot be tested until we get a data set that includes *both* power data and lap data (#46).
Hi! Since this issue has been open for a long time, I would like to ask, if you still need the test data? A colleague of mine and I stumbled upon your software a couple of days ago and it works much better for us, than the outdated V800 downloader which includes your old code. We would be happy to contribute! Are there any other requirements besides "Laps and Power"? We can send you data from a V800 with Polar Look Kéo Power Pedals. Cheers |
Hi @remifreiwald, thanks, some test data would be great!! 👍 No requirements other than Laps and Power. Minimum number of laps would be 2, I guess, but 3 would be nicer. Any more than 3 is fine, but unnecessary. No minimum distance / cadence. The laps can be quite short if you like. Indeed, its better if they are pretty short so the total data is not too big (won't hurt - just make the tests run a bit slower). BTW, I have my own fork of the v800_downloader that I keep up to date with my Bipolar code - https://github.com/pcolby/v800_downloader Feel free to use it, or Bipolar, or both, in whatever combination works for you :) Thanks! |
Hi @pcolby Attached you will find a short training session including power data and 4 short laps taken directly from the Bipolar export folder. I also included the resulting TCX and CSV files from the Flow Webservice, just in case you need a final result to compare against. Cheers |
This is the verbatim data that @remifreiwald provided at #46 (comment) for adding unit tests for laps with power.
This is the verbatim data that @remifreiwald provided at #46 (comment) for adding unit tests for laps with power.
Thanks @remifreiwald, I've added your test data to the repo now. Thanks! 😄 |
Bipolar contains a few branches of code that only get executed if we have lap data with power data. Currently, we have a number of test data sets for lap data, and one test data set for power data, but no sets with both lap and power data.
I, personally, don't have any power sensors, so if someone could provide such a test data set sometime, that would be brilliant!! 😄
Note, the data set would not need to be large - eg just a couple of minutes on a spin bike would suffice, so long as it include a few short laps (and uses a power sensor, of course).
The text was updated successfully, but these errors were encountered: