Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swimming data #75

Closed
pcolby opened this issue Nov 16, 2016 · 4 comments
Closed

Swimming data #75

pcolby opened this issue Nov 16, 2016 · 4 comments
Assignees
@pcolby
Labels
help wanted ready for release

Comments

@pcolby
Copy link
Owner

pcolby commented Nov 16, 2016

... would be great to have some for unit tests.
@remifreiwald
Copy link

Maybe I can help here out, too. Haven't been swimming the last couple of weeks, but I'm intending to go on Friday.

Any requirements?

@pcolby
Copy link
Owner Author

pcolby commented Nov 16, 2017

Thanks @remifreiwald, that would be great! 😄 Can't really think of any requirements... I guess just multiple laps. Ideally with GPS (if you're swimming outdoors) and HR, but neither is critical.

Thanks!

@remifreiwald
Copy link

Since it's getting pretty cold outside I opted for the indoor pool... ;)

The zip file contains two folders:

  1. A session with 3 laps
  2. A session without laps

Both sessions consist of 150m swimming in a 25m pool, resulting in 6 pool lengths per session. The V800 recognized all turns correctly.

The laps were taken every 50m but not at the end of the session, since I just stopped the recording.

If you need more data, tag me! ;)

pool swimming.zip

pcolby added a commit that referenced this issue Nov 18, 2017
@pcolby
Add swimming test data from @remifreiwald #75
5adde6c 
This is the verbatim data that @remifreiwald provided at
#75 (comment)
pcolby added a commit that referenced this issue Nov 18, 2017
@pcolby
Rename the swimming test data for consistency #75
19c2d11
pcolby added a commit that referenced this issue Nov 18, 2017
@pcolby
Include swimming data in tests #75
9a94f68 
Note, the swimming data does produce some warnings, which will be
looked into soon:

```
QWARN  : TestTrainingSession::parseLaps(training-sessions-1942173310-exercises-1948583962-laps) "1/2/8/1" wire type 0 does not match expected wire type 5 for scalar type 2 .
QWARN  : TestTrainingSession::parseLaps(training-sessions-1942173310-exercises-1948583962-laps) "1/2/8/1" wire type 0 does not match expected wire type 5 for scalar type 2 .
QWARN  : TestTrainingSession::parseLaps(training-sessions-1942173310-exercises-1948583962-laps) "1/2/8/1" wire type 0 does not match expected wire type 5 for scalar type 2 .
...
QWARN  : TestTrainingSession::parseStatistics(training-sessions-1942173160-exercises-1948583842-statistics) "12/4/6" wire type 5 does not match expected wire type 0 for scalar type 5 .
QWARN  : TestTrainingSession::parseStatistics(training-sessions-1942173310-exercises-1948583962-statistics) "12/4/6" wire type 5 does not match expected wire type 0 for scalar type 5 .
...
QWARN  : TestTrainingSession::toGPX(training-sessions-1942173160) "12/4/6" wire type 5 does not match expected wire type 0 for scalar type 5 .
QWARN  : TestTrainingSession::toGPX(training-sessions-1942173310) "1/2/8/1" wire type 0 does not match expected wire type 5 for scalar type 2 .
QWARN  : TestTrainingSession::toGPX(training-sessions-1942173310) "1/2/8/1" wire type 0 does not match expected wire type 5 for scalar type 2 .
QWARN  : TestTrainingSession::toGPX(training-sessions-1942173310) "1/2/8/1" wire type 0 does not match expected wire type 5 for scalar type 2 .
QWARN  : TestTrainingSession::toGPX(training-sessions-1942173310) "12/4/6" wire type 5 does not match expected wire type 0 for scalar type 5 .
```
pcolby added a commit that referenced this issue Nov 18, 2017
@pcolby
Correct some swimming-related protobuf fields
8b3d2b0 
These fields (two specific to swimming laps, and one specific to
swimming stats) are not actually used in any output formats (ie not
HRM, GPX, nor TCX), but good to parse their correct values for possible
future output formats or extensions.

Big thanks to @remifreiwald for providing the test data (in #75) that
revealed these errors :)
@pcolby pcolby self-assigned this Nov 18, 2017
@pcolby
Copy link
Owner Author

pcolby commented Nov 18, 2017

Thanks again @remifreiwald!! 😄

I've incorporated the swimming data into the test suite.

Interestingly, the data revealed a couple of minor bugs in my protobuf definitions... these affect parsing only, not any values that get used in the output formats, but still good to get fixed! See 8b3d2b0 for details.

Thanks again!

@pcolby pcolby closed this as completed Nov 18, 2017
@remifreiwald remifreiwald mentioned this issue Jan 17, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcolby pcolby

Labels
help wanted ready for release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@remifreiwald @pcolby