Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User roster enhancements #448

Open
3 of 4 tasks
jamesdabbs opened this issue Dec 4, 2015 · 6 comments
Open
3 of 4 tasks

User roster enhancements #448

jamesdabbs opened this issue Dec 4, 2015 · 6 comments
Assignees
Milestone

Comments

@jamesdabbs
Copy link
Member

A few things here -

  • PCMOs can manage a roster for their country
  • Live searching
  • Toggle for active / inactive
  • If filtering for actives, and no results are found, switch to including inactives
@jamesdabbs jamesdabbs modified the milestone: Sprint Dec 4, 2015
@jamesdabbs jamesdabbs self-assigned this Dec 5, 2015
@jamesdabbs
Copy link
Member Author

Oh, general question for @choquette33 @aroberts01 - as it stands, uploading a CSV completely clobbers any edits that users themselves / PCMOs make. Long term, it'd be great to track when users make changes and push them back to the central DB ... but that's probably a lot of work. For now: should we disable non-admins from editing user records?

@choquette33
Copy link
Member

@jamesdabbs That's tough.... is there anything else we could do?

@aroberts01
Copy link

@choquette33 we need to look at staging calendars-I think it's fine that it wipes out user updates. Volunteers need to be updating their information on VIDA for security reasons- that information needs to be up to date. I like that we have a feature that the vol can update thier information in real time- lets say they lose their phone and get a new number. That being said- they also need to have it updated in VIDA- for security purposes- so when the CSV is uploaded again- there should be no inconsistancy. Does this make sense? I'm in support of the CSV completely clobbering any edits the users themselves make. I'm drinking the Peace Corps Safety & Security VIDA kool aid.

@jamesdabbs
Copy link
Member Author

First three items are done in 8aa36b7. An active / inactive toggle is surprisingly subtle (should it automatically flip as you're live searching), so it'd be my inclination to punt on that. Do we expect PCMOs to ever look at inactive users, other than in the "I have a specific user in mind that I'm searching for" case that we talked about?

As far as allowing user edits, the options that I see are:

  • Build an integration with VIDA such that changes in Medlink are immediately pushed to VIDA
  • Build a notification system such that changes made in Medlink are also sent to someone who is responsible for updating VIDA so that the changes aren't lost in the next update (and you're just out of luck if you happen to make a change at the same time as an upload is going through)
  • Store a full list of all edits that a user has made in Medlink and merge them with new uploads. The question to resolve there is: if the user has changed something, and VIDA has changed something, and the changes are incompatible ... what do we do?

None of those are great, and all of those are rather a lot of work.

@buwanekag
Copy link
Collaborator

@aroberts01 - Apologies for the delay in getting back to you, I can definitely send you screen shots of all the view instances to get a structural idea of what it looks like and then we can start on moving things around and also adding changes, let me know what you think is best.

@choquette33
Copy link
Member

@jamesdabbs @aroberts01 - The clobbering of edits is an ok solution since VIDA is the authoritative source. However, I think we need to allow users to continue to edit their own profile data since that provides a quick solution for users. I suggest we move forward with a clobbering of edits, but retain the ability for users/PCMOs/Admins to edit profile info.

Basic argument here is that a sync with VIDA would be so infrequent that most fixes in medlink would be reflected in VIDA by the time the next upload happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants