-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Enterprise Compatibility #579
Comments
Since I have no environment of GitHub Enterprise Server, I was looking forward to this issue, thanks! actions-gh-pages/src/set-tokens.ts Line 66 in a0db9b6
We can modify the function |
Those are also helpful for us. export function getServerUrl(): URL {
// todo: remove GITHUB_URL after support for GHES Alpha is no longer needed
return new URL(
process.env['GITHUB_SERVER_URL'] ||
process.env['GITHUB_URL'] ||
'https://github.com'
)
} const serverUrl = getServerUrl()
return `https://x-access-token:${githubToken}@${serverUrl.hostname}/${publishRepo}.git`; |
Should we read the ENV variable or should it be handed into the action by an |
The former is the best because |
On it, expect PR 🔄 |
Changes for #579 Co-authored-by: dom <[email protected]>
Changes for #579 Co-authored-by: dom <[email protected]>
I can do that today! |
|
@dominikmeyersap Could you try The release |
I am running this action on a self-hosted runner dedicated to a GHES repository, and seeking a way to publish the pages to an external repository on github.com to deliver documents for our customers. The issue is, the current implementation is not applicable for this kind of usages.
There should be a few ideas to resolve this. One approach I can imagine is introducing an optional parameter such as |
I can not find an option (a clean one) that allows to set the Server URL or Api Url and they seem to be hardcoded to github.com.
This fails because our repo is at https://github.tools.sap/coresystemsFSM/blog
As we want to use your action with GitHub Enterprise we would need to be able to customise those.
Link to your contents
I see one entry here but I think its unused during a workflow.
actions-gh-pages/Dockerfile
Line 36 in c1c219f
Additional context
I would contribute a PR if you give me 1-2 pointers where I'd need to add things in your structure.
The text was updated successfully, but these errors were encountered: