Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Links for Cloud and Containers Pentesting #373

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

galoget
Copy link
Contributor

@galoget galoget commented Jul 24, 2023

  • Update script 2_container.sh to fix broken links to Kubernetes Pentesting.
  • Update script 3_cloud.sh to fix a broken link to GCP Pentesting.

Update script 3_cloud.sh to fix a broken link to GCP Pentesting.
Update script 2_container.sh to fix broken links to Kubernetes Pentesting.
@github-actions
Copy link

After analyzing the provided PR patches, here are my findings:

  1. linPEAS/builder/linpeas_parts/2_container.sh:
  • Line 286: The TOKEN variable is being assigned the value of a file content without any validation or sanitization. This could potentially lead to a security issue if the file content is manipulated by an attacker. It's recommended to validate and sanitize the input before using it.

  • Line 368: The kubectl auth can-i --list 2>/dev/null command is being executed without any error handling. If the command fails, the script will continue to execute, which could lead to unexpected behavior. It's recommended to add error handling to this command.

  • Line 369: The curl command is being used to send a POST request with a hardcoded base64 encoded string. This could potentially be a security issue if the encoded string contains sensitive information. It's recommended to avoid hardcoding sensitive information in the code.

  1. linPEAS/builder/linpeas_parts/3_cloud.sh:
  • Line 157: The eval command is being used, which can be a security risk as it executes the argument as a shell command. This can lead to command injection if the argument is not properly sanitized. It's recommended to avoid using eval if possible, or ensure that the argument is properly sanitized before use.

Please note that these are potential issues and might not be actual vulnerabilities depending on the context and usage of the script. It's recommended to review these points and apply the necessary fixes or mitigations.

@carlospolop carlospolop merged commit 667bb52 into peass-ng:master Jul 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants