Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parsing of wildcard rule #159

Open
JustinAlia opened this issue Jun 7, 2024 · 1 comment
Open

Incorrect parsing of wildcard rule #159

JustinAlia opened this issue Jun 7, 2024 · 1 comment

Comments

@JustinAlia
Copy link

When attempting to parse 'salesforce.com' domain ends up being null

const { domain } = parseDomain('salesforce.com');

@jhnns
Copy link
Member

jhnns commented Aug 11, 2024

Thanks for submitting it. This is actually a bug. The salesforce rule contains a * and there are a few ambiguities as to how this should be handled. Here is the relevant issue: publicsuffix/list#694

I don't know when I'll get to it. You are welcome to open a PR.

@jhnns jhnns changed the title Not parsing correct domain Incorrect parsing of wildcard rule Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants