New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unsafe regex #1

Open

hpohlmeyer opened this issue Apr 14, 2021 · 0 comments

Member

hpohlmeyer commented Apr 14, 2021

We currently use an unsafe regex to search for the expect-error comments:

typescript-exercises-tools/src/diagnostics.ts

Line 7 in 74b9dba

    
           const regex = /([\t ]*?\/\/ 💥? ?Expect error (\d+):? ?(.*?)\n)(?:\n|\s|.*?\/\/ 💥? ?Expect error \d+.*?\n)*([^\n\r]*)/g;

This could be a performance burden. We should rewrite it to have a lower complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment