Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate invalid param 'text' warning for /v1/search #1621

Open
missinglink opened this issue Apr 21, 2022 · 4 comments
Open

duplicate invalid param 'text' warning for /v1/search #1621

missinglink opened this issue Apr 21, 2022 · 4 comments
Labels

Comments

@missinglink
Copy link
Member

/v1/search

Screenshot 2022-04-21 at 12 18 02

/v1/autocomplete

Screenshot 2022-04-21 at 12 18 12

@orangejulius
Copy link
Member

Wow, never noticed that before. I wonder where it comes from.

@missinglink
Copy link
Member Author

missinglink commented Apr 21, 2022

I think the core issue is that the 'combining sanitizers' (such as https://github.com/pelias/api/blob/master/sanitizer/search.js) should return immediately upon error rather than running through the rest of the route chain.

@missinglink
Copy link
Member Author

ie. here https://github.com/pelias/api/blob/master/sanitizer/sanitizeAll.js#L94 it should return something to trigger the err in express middleware (req, res, err).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants