From ae0aa7bb588681a0b55fa974d48224553d38dc81 Mon Sep 17 00:00:00 2001
From: missinglink <insomnia@rcpt.at>
Date: Fri, 24 Apr 2020 16:04:10 +0200
Subject: [PATCH] test(central_european_streets): add additional tests

---
 classifier/CentralEuropeanStreetNameClassifier.js | 6 ++++++
 test/address.deu.test.js                          | 5 +++++
 test/address.fra.test.js                          | 4 ++++
 3 files changed, 15 insertions(+)

diff --git a/classifier/CentralEuropeanStreetNameClassifier.js b/classifier/CentralEuropeanStreetNameClassifier.js
index 5c1ea0c7..4fba6dc9 100644
--- a/classifier/CentralEuropeanStreetNameClassifier.js
+++ b/classifier/CentralEuropeanStreetNameClassifier.js
@@ -26,6 +26,12 @@ class CentralEuropeanStreetNameClassifier extends SectionClassifier {
     // other elements cannot contain any public classifications
     if (_.some(first.classifications, (c) => c.public)) { return }
 
+    // optionally check parent phrases too?
+    // if (_.some(first.graph.findAll('parent'), (p) => {
+    //   if (p.norm !== first.norm) { return false }
+    //   return _.some(p.classifications, (c) => c.public)
+    // })) { return }
+
     // assume the first token is a street name
     first.classify(new StreetClassification(0.5))
   }
diff --git a/test/address.deu.test.js b/test/address.deu.test.js
index 8d74f194..4d7c600c 100644
--- a/test/address.deu.test.js
+++ b/test/address.deu.test.js
@@ -27,6 +27,11 @@ const testcase = (test, common) => {
     { locality: 'Munich' }, { country: 'Germany' }
   ])
 
+  assert('Esplanade 17, Berlin', [
+    { street: 'Esplanade' }, { housenumber: '17' },
+    { locality: 'Berlin' }
+  ])
+
   assert('Königsallee Düsseldorf', [
     { street: 'Königsallee' },
     { locality: 'Düsseldorf' }
diff --git a/test/address.fra.test.js b/test/address.fra.test.js
index 0e09973e..894fdd28 100644
--- a/test/address.fra.test.js
+++ b/test/address.fra.test.js
@@ -108,6 +108,10 @@ const testcase = (test, common) => {
   assert(`10 Boulevard Saint-Germains Paris`, [
     { housenumber: '10' }, { street: `Boulevard Saint-Germains` }, { locality: 'Paris' }
   ])
+
+  assert(`Paris 75000, France`, [
+    { locality: 'Paris' }, { postcode: '75000' }, { country: 'France' }
+  ])
 }
 
 module.exports.all = (tape, common) => {