open_graph.py's _create_absolute_fileurl method does not honor a SITEURL with a subdirectory

[fluid217]

Given

SITEURL = 'mysite.com/blog' in the Pelican settings file.
and a fileurl of 'posts/my_article/index.html`

the _create_absolute_fileurl method in open_graph.py will return a file_url missing the SITEURLs subdirectory.
This is due to the way that urllib's parse.urljoin works.

My quick workaround for now is to append a slash to the siteurl. If it's redundant, it will be stripped out by urljoin

def __init__(
       self, siteurl, fileurl, file_type, title, description, image, locale
      ) -> None:
          self.siteurl = siteurl + "/"

[buanzo]

I am having the same issue. My Pelican is in a subfolder of my domain, example.com/blog, and the image/og_image attributes begin with /images/... - The resulting image url lacks the /blog before /images/.

[buanzo]

Maybe something like this, to avoid making sure SITEURL ends with '/':

def _create_absolute_fileurl(self):
    """Join site URL and file path."""
    # Ensure fileurl is a relative path
    if self.fileurl.startswith('/'):
        relative_fileurl = self.fileurl[1:]
    else:
        relative_fileurl = self.fileurl

    file_url = parse.urljoin(self.siteurl, relative_fileurl)
    return file_url

[MaevaBrunelles]

Hello @buanzo,

Feel free to open a PR with the patch and tests that ensure the canonical URL is well generated :)

[buanzo]

Absolutely! I'm working on the injector plugin, then tackle some bugs. Is there a devs mailing list ?