Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After making a selection with the Select tool, auto-switch to Move tool #1792

Open
shieldgenerator7 opened this issue Oct 6, 2023 · 2 comments · May be fixed by #1793
Open

After making a selection with the Select tool, auto-switch to Move tool #1792

shieldgenerator7 opened this issue Oct 6, 2023 · 2 comments · May be fixed by #1793
Labels
Enhancement Move Tool Select Tool UX Related to the way users interact with the program

Comments

@shieldgenerator7
Copy link

Issue Summary

Related discussion:
https://discuss.pencil2d.org/t/suggestion-implementing-automatic-move-tool-on-bitmap-layers/609

When the user makes a selection with the Select tool, automatically switch to the Move tool so they can edit the picture.

Actual Results

Currently the user has to manually switch to the Move tool every time.

Expected Results

Ideally the program would auto switch to the Move tool for the user.

Steps to reproduce

  1. Select the Select tool
  2. Use the Select tool to select an area
  3. Result: The Select tool is still the active tool, but it should be the Move tool
@shieldgenerator7
Copy link
Author

I'm working on this already

shieldgenerator7 added a commit to shieldgenerator7/pencil that referenced this issue Oct 6, 2023
shieldgenerator7 added a commit to shieldgenerator7/pencil that referenced this issue Oct 6, 2023
shieldgenerator7 added a commit to shieldgenerator7/pencil that referenced this issue Oct 6, 2023
shieldgenerator7 added a commit to shieldgenerator7/pencil that referenced this issue Oct 6, 2023
@Jose-Moreno Jose-Moreno added Enhancement UX Related to the way users interact with the program Select Tool Move Tool labels Oct 8, 2023
@Jose-Moreno
Copy link
Member

@shieldgenerator7 Hi thank you for this!

There is certainly an issue with the overall select-transform workflow in Pencil2D. From a single responsibility POV each tool has a singular functionality. It wouldn't make sense for the select tool to switch automatically to the move tool without the user input.

However from an actual animation workflow, it is much desired to have this! Which is why most of the time there is a single tool implemented to perform both Selection & basic transformation operations on raster & vector artwork, particularly in software like Adobe Animate or Toonboom Harmony which Pencil2D shares commonalities with.

For this particular request I don't see any issue. Having such a helper function for those who want this would be probably a huge performance boost 🥳

@J5lx J5lx linked a pull request Oct 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Move Tool Select Tool UX Related to the way users interact with the program
Projects
Status: Discussion
Development

Successfully merging a pull request may close this issue.

2 participants