diff --git a/core/src/main/java/org/pentaho/platform/util/ActionUtil.java b/core/src/main/java/org/pentaho/platform/util/ActionUtil.java index 76132b52430..1fbd18e2b6b 100644 --- a/core/src/main/java/org/pentaho/platform/util/ActionUtil.java +++ b/core/src/main/java/org/pentaho/platform/util/ActionUtil.java @@ -437,39 +437,43 @@ public static void sendEmail( Map actionParams, Map 0) { + emailer.setTo(emailGroupResolver.resolve(to)); + emailer.setCc(emailGroupResolver.resolve(cc)); + emailer.setBcc(emailGroupResolver.resolve(bcc)); + + String subject = (String) actionParams.get("_SCH_EMAIL_SUBJECT"); + if (subject != null && !"".equals(subject)) { + emailer.setSubject(subject); + } else { + emailer.setSubject("Pentaho Scheduler" + (emailer.getAttachmentName() != null ? " : " + emailer.getAttachmentName() : "")); + } + String message = (String) actionParams.get("_SCH_EMAIL_MESSAGE"); + if (subject != null && !"".equals(subject)) { + emailer.setBody(message); + } + emailer.send(); } else { - emailer.setSubject( "Pentaho Scheduler" + ( emailer.getAttachmentName() != null ? " : " + emailer.getAttachmentName() : "" ) ); - } - String message = (String) actionParams.get( "_SCH_EMAIL_MESSAGE" ); - if ( subject != null && !"".equals( subject ) ) { - emailer.setBody( message ); + logger.error(Messages.getInstance().getErrorString("ActionUtil.ERROR_0001_INVALID_EMAIL_LIST")); } - emailer.send(); } catch ( Exception e ) { logger.warn( e.getMessage(), e ); } diff --git a/core/src/main/resources/org/pentaho/platform/util/messages/messages.properties b/core/src/main/resources/org/pentaho/platform/util/messages/messages.properties index 729e33476ac..a63e7c0e8aa 100644 --- a/core/src/main/resources/org/pentaho/platform/util/messages/messages.properties +++ b/core/src/main/resources/org/pentaho/platform/util/messages/messages.properties @@ -55,4 +55,4 @@ VersionCheck.NO_RESULT_MESSAGE=Version Check Error: No Results Available ActionUtil.ERROR_0001_REQUIRED_PARAM_MISSING=Property "{0}" or "{1}" must be set in the action data map ActionUtil.ERROR_0002_FAILED_TO_CREATE_ACTION=Failed to create an instance of action "{0}" ActionUtil.ERROR_0003_ACTION_WRONG_TYPE=class {0} must be an instance of "{1}" - +ActionUtil.ERROR_0001_INVALID_EMAIL_LIST=Unable to send email. The list of the recipients is invalid