From 4785af5f7b3c7e55b72110204d6eab738547bf05 Mon Sep 17 00:00:00 2001 From: singletonc Date: Fri, 2 Feb 2024 18:55:22 -0500 Subject: [PATCH] [BACKLOG-39812] PIR report doesnt render in New Window or Via Deeplink - provide temporary workaround so that opened, deep-linked reports will render in new tabs - this breaks burger tabs menu in that this first tab will not be accessible in burger mode --- .../org/pentaho/mantle/client/ui/tabs/MantleTabPanel.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/user-console/src/main/java/org/pentaho/mantle/client/ui/tabs/MantleTabPanel.java b/user-console/src/main/java/org/pentaho/mantle/client/ui/tabs/MantleTabPanel.java index 46d1ac569ee..166325bb215 100644 --- a/user-console/src/main/java/org/pentaho/mantle/client/ui/tabs/MantleTabPanel.java +++ b/user-console/src/main/java/org/pentaho/mantle/client/ui/tabs/MantleTabPanel.java @@ -130,6 +130,9 @@ public void addTab( String text, String tooltip, boolean closeable, Widget conte selectTab( tab ); } MantleTabMenuItem menuItem = createTabMenuItem( tab ); + if( tabsSubMenuBar == null || tabsMenuBar == null ){ + return; //TODO bypass implemented as a race condition workaround for BACKLOG-39781 + } linkTabToMenuItem( tab, menuItem ); tabsSubMenuBar.addItem( menuItem ); contextMenuRefreshThreshold( true ); @@ -164,7 +167,7 @@ public void updateTabMenuText( PentahoTab selectedTab ) { tabsMenuItem.setText( "" ); } else { tabsMenuBar.removeStyleName( CLASS_EMPTY_TABS_MENU ); - String tabMenuText; + String tabMenuText = ""; int tabCount = getTabCount(); if ( tabCount > 1 ) { int tabIndex = tabsSubMenuBar.getItemIndex( getLinkedTabMenuItem( selectedTab ) ) + 1;