Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcli: migrate balance function #4831

Closed
4 of 5 tasks
Tracked by #4849
aubrika opened this issue Aug 23, 2024 · 2 comments · Fixed by #4848
Closed
4 of 5 tasks
Tracked by #4849

pcli: migrate balance function #4831

aubrika opened this issue Aug 23, 2024 · 2 comments · Fixed by #4848
Assignees
@cronokirby @aubrika
Labels
A-client Area: Design and implementation for client functionality C-enhancement Category: an enhancement to the codebase _P-high High priority
Milestone
Sprint 12

Comments

@aubrika
Copy link
Contributor

aubrika commented Aug 23, 2024 •
edited by conorsch
Loading

We should change pcli to have a new tx subcommand, pcli tx migrate, which takes the destination FVK as a parameter and then constructs a transaction that:

  • has the memo field “migrate from penumbrafullviewingkey1… to penumbrafullviewingkey1…”
  • spends every single note from every account
  • replicates the balances per account in the wallet of the provided destination FVK (minus any transaction fees)
  • pays the fees for this transaction from the lowest-numbered account with sufficient funds
  • include help text in clap explaining that this is for migrating custody mechanisms
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Aug 23, 2024
@aubrika aubrika added this to the Sprint 11 milestone Aug 23, 2024
@aubrika aubrika added A-client Area: Design and implementation for client functionality C-enhancement Category: an enhancement to the codebase _P-high High priority and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Aug 23, 2024
@aubrika aubrika mentioned this issue Aug 23, 2024
Closed
2 tasks
@aubrika aubrika added this to Penumbra Aug 23, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Aug 23, 2024
@aubrika aubrika self-assigned this Aug 26, 2024
@aubrika aubrika moved this from Backlog to Todo in Penumbra Aug 26, 2024
@cronokirby cronokirby self-assigned this Sep 4, 2024
@cronokirby
Copy link
Contributor

Not quite done yet because we're not replicating the account structure

@conorsch
Copy link
Contributor

conorsch commented Sep 5, 2024

replicates the balances per account in the wallet of the provided destination FVK (minus any transaction fees)

Ah, I didn't notice this was in the spec: thought the changes in #4842 were sufficient to close.

@cronokirby cronokirby mentioned this issue Sep 6, 2024
Merged
1 task
@aubrika aubrika modified the milestones: Sprint 11, Sprint 12 Sep 9, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra Sep 9, 2024
@conorsch conorsch mentioned this issue Sep 9, 2024
Closed
2 tasks
conorsch added a commit to penumbra-zone/guide that referenced this issue Sep 10, 2024
@conorsch
docs: add 'pcli migrate balance' explainer
f65458f 
Adds a short explainer for how the `pcli migrate balance` functionality
works. Refs:

* penumbra-zone/penumbra#4831
* penumbra-zone/penumbra#4849
@conorsch conorsch mentioned this issue Sep 10, 2024
Merged
conorsch added a commit to penumbra-zone/guide that referenced this issue Sep 10, 2024
@conorsch
docs: add 'pcli migrate balance' explainer
40e8b61 
Adds a short explainer for how the `pcli migrate balance` functionality
works. Refs:

* penumbra-zone/penumbra#4831
* penumbra-zone/penumbra#4849
@conorsch conorsch mentioned this issue Sep 10, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cronokirby cronokirby

@aubrika aubrika

Labels
A-client Area: Design and implementation for client functionality C-enhancement Category: an enhancement to the codebase _P-high High priority
Projects
Penumbra
Archived in project
Milestone
Sprint 12
Development

Successfully merging a pull request may close this issue.

pcli migrate balance: replicate account structure penumbra-zone/penumbra
3 participants
@conorsch @cronokirby @aubrika