Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different height of pictures on home page #127

Open
hmoldenhauer opened this issue Sep 21, 2017 · 5 comments
Open

different height of pictures on home page #127

hmoldenhauer opened this issue Sep 21, 2017 · 5 comments

Comments

@hmoldenhauer
Copy link
Contributor

The pictures on our home page have different height. This looks a bit unprofessional. We should change this.

@maxnoe
Copy link
Member

maxnoe commented Sep 21, 2017

Which pictures exactly?

@hmoldenhauer
Copy link
Contributor Author

pictures of two adjecent posts on https://pep-dortmund.org/
for Example the 'Sommerakademie 2017' and 'Anmeldestatus Sommerakademie 2017'
or more obvious 'Hackathon 2017' and 'Girls'Day 2017'

@hmoldenhauer
Copy link
Contributor Author

hmoldenhauer commented Nov 8, 2017

all images should have the same aspect ratio. I suggest 1:2

@bixel
Copy link
Member

bixel commented Nov 9, 2017

This might be pretty hard to enforce, but I would agree the ratio should be somewhere between 1:2 and 1:1. Since we already had floating posts on the home page at some point, different post heights should not be a problem and indeed are a nice-looking feature of our design template. The only problem is that we need to add some javascript to automatically reorder the posts for different device widths.

@hmoldenhauer
Copy link
Contributor Author

we should ask everyone to stick to this aspect ratio. When reviewing posts one could also check if the image has the ratio of 1:2. Complete automatic enforcing is not needed. One could do it manually if someone is bored ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants