Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow roadblock messages to be sent from any engine to any other engine #390

Open
atheurer opened this issue May 2, 2023 · 1 comment
Open

Comments

@atheurer
Copy link
Contributor

atheurer commented May 2, 2023

Currently sending from one engine to another, like a server to a client, appears to be limited to the engines with the same "cs_id" (client-1 to server-1). We need to ability to send to/from any cs_id. For example, in trafficgen, server-N needs to send info to client-1.

This limitation is not in roadblock, but probably implemented in the engine code for convenience, back when we would only communicate between clients & servers with the same cs_id.

@atheurer
Copy link
Contributor Author

The actual current message reception filtering logic has, in evaluate_test_roadblock() from the engine-script-library:

  • If the sender is your "$cs_buddy" and it send to "all", you get the message
    • for example, client-1 sends to "all", only "server-1" gets this message
    • this was done to make it easy for clients/server to send to their "buddy" without having to send to a specific recipient
    • this may not be necessary any more with a few changes to benchmark scripts, having the sender always address a specific recipient.
  • if the sender targets a specific client/server, then message should always gets delivered
    • for example server-3 sends a message addressed only to client-1, client-1 should get this message
    • only example I can think of doing this may be sending to endpoints for things like "endpoint-start" and "endpoint-stop"
    • this is likely what trafficgen server (testpmd) script needs to do when there are N servers and 1 client, send to client-1 specifically

@k-rister FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant