Skip to content
This repository has been archived by the owner on Apr 19, 2022. It is now read-only.

[Event] 2019 Fall Event Support #390

Open
mrmin123 opened this issue Nov 29, 2019 · 8 comments
Open

[Event] 2019 Fall Event Support #390

mrmin123 opened this issue Nov 29, 2019 · 8 comments
Assignees
Labels

Comments

@mrmin123
Copy link
Collaborator

  • Needs panel and next-page visual assets
  • Needs map json assets with node names and locations and edges (new with v8.0.0-rc1)
@mrmin123 mrmin123 added the event label Nov 29, 2019
@mrmin123 mrmin123 self-assigned this Nov 29, 2019
@mrmin123 mrmin123 pinned this issue Nov 29, 2019
@mrmin123
Copy link
Collaborator Author

390-2019-fall-event; preliminary data courtesy of @perryhuynh

@mrmin123
Copy link
Collaborator Author

mrmin123 commented Dec 1, 2019

Pushed a number of changes to the event branch that should fix navigation to the event maps.

@mrmin123
Copy link
Collaborator Author

mrmin123 commented Dec 2, 2019

Event branch has been updated multiple times with fixes and updates to both panel and json asset updates. Additional changes:

  • Add logic to dismiss boss dialogues
  • Fix so that event reset does not fire even when it is disabled

@tsuki-tsuki
Copy link

tsuki-tsuki commented Dec 10, 2019

Node recognition sometimes missed when using v8.
Is this known issue?

Also can night battle settings use old mode (battle num.) from GUI? When manually edit the config file, kcauto can read it as expected, but there's no option to add using battle num. from GUI.

Overall, loving this new implementation. Still not as stable as the old one, but consumes less CPU than before. Keep up the good job!

@mrmin123
Copy link
Collaborator Author

@tsuki-tsuki the inability to specify node by count for night battles is a bug. I'll fix that eventually, but for now please modify the config manually. Apologies for the inconvenience.

As for the node recognition, I'm not sure what you mean by this? Are you saying that sometimes kcauto doesn't understand that it arrived at a new node? aka gets stuck in a loop before choosing a formation?

And thanks, glad you like the new version!

@tsuki-tsuki
Copy link

tsuki-tsuki commented Dec 11, 2019 via email

@tsuki-tsuki
Copy link

tsuki-tsuki commented Dec 11, 2019

Here's the expedition log.
Should I just open an issue?

Expedition stuck log [2019-12-12 01:30:21] kcauto has been running for 0d 3h 16m 48s (loop 51).

[2019-12-12 01:30:21] Next sortie at 2019-12-11 23:15:19 / 5 sorties (1.52/hr) / 20 nodes fought (6.10/hr) / 3 ships rescued (0.91/hr) / 1 (0.30/hr)

[2019-12-12 01:30:21] 1 Expeditions sent (0.30/hr) / 5 Expeditions received (1.52/hr)

[2019-12-12 01:30:21] Fleet 1 / Minor fleet damage / No Fatigue

[2019-12-12 01:30:21] Fleet 2 / Minor fleet damage / No Fatigue

[2019-12-12 01:30:21] Fleet 3 / On expedition / Returning at 2019-12-12 01:02:10

[2019-12-12 01:30:21] Fleet 4 / On expedition / Returning at 2019-12-11 23:41:37

---redacted---

[2019-12-12 01:30:41] Fleets 3 and 4 have returned!

It looks like expedition return is detected, but next expedition is never sent.

@mrmin123
Copy link
Collaborator Author

@tsuki-tsuki yea, open another issue please to track the issue. Please also include the config file. How did kcauto send only 1 expedition but receive 5? Did you manually send expeditions?

Also, you should now be able to specify night battles by node number in the GUI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants