Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on sox to split/trim wave files #182

Open
shuttle1987 opened this issue Aug 1, 2018 · 5 comments
Open

Remove dependency on sox to split/trim wave files #182

shuttle1987 opened this issue Aug 1, 2018 · 5 comments
Labels
easy-first Good issues for people new to the codebase low-priority lower priority tasks refactor

Comments

@shuttle1987
Copy link
Member

If desired we could implement a pure python standard library only version of functions like trim_wav_ms by using the wave module https://docs.python.org/3/library/wave.html

@shuttle1987 shuttle1987 added refactor low-priority lower priority tasks labels Aug 1, 2018
@oadams
Copy link
Collaborator

oadams commented Aug 5, 2018

That would be good but I agree with your labelling this low-priority. Calling sox for now is fine.

@shuttle1987
Copy link
Member Author

shuttle1987 commented Aug 5, 2018

I guess one thing is that sox may be a whole lot faster depending on how the standard library wave module is implemented. This might be a good first issue for someone to contribute?

@oadams oadams added the easy-first Good issues for people new to the codebase label Aug 5, 2018
@oadams
Copy link
Collaborator

oadams commented Aug 5, 2018

Sure, since it's pretty orthogonal to everything else.

@shuttle1987
Copy link
Member Author

It seems as though Kaldi needs sox anyway

@shuttle1987
Copy link
Member Author

I think this might be a situation where it makes sense to use this standard library function as a fallback only if sox is not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy-first Good issues for people new to the codebase low-priority lower priority tasks refactor
Projects
None yet
Development

No branches or pull requests

2 participants