Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RosJointStateClient is a bit of a mess #613

Open
egordon opened this issue Sep 30, 2021 · 0 comments
Open

RosJointStateClient is a bit of a mess #613

egordon opened this issue Sep 30, 2021 · 0 comments

Comments

@egordon
Copy link
Contributor

egordon commented Sep 30, 2021

There are a few key issues with the RosJointStateClient:
https://github.com/personalrobotics/aikido/blob/master/src/control/ros/RosJointStateClient.cpp

(1) There's no reason to lock the mSkeleton mutex in spin, since we don't read or write from it at all.

(2) There is not reason to store the mSkeleton pointer anyway, since we never use it.

(3) We should decide on a better interface. Either [1] we should pass in a MetaSkeletonPtr (assuming the parent skeleton is already locked) and set the corresponding (subset of) DoFs directly, or [2] we should just return a copy of the buffer as a map from DoF name to position, and have the client set their own MetaSkeleton accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant