You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like to create a personal package that allows me to add a
make:pest
command that is exactly the same as pest:test . In general this can be easily achieved by simply extending from the existing PestTestCommand and overwriting the signature. This works perfectly and is in my opinion a valid way of adding functionality that I would like without it being added to the main project if undesired (#560 ).
However I am unable to do this as PestTestCommand is labeled final in the code.
Is it possible to remove the final label from the PestTestCommand? Is there a particular reason final is provided for this class?
I am happy to submit a PR if this is felt that it might be accepted.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I would like to create a personal package that allows me to add a
command that is exactly the same as
pest:test
. In general this can be easily achieved by simply extending from the existing PestTestCommand and overwriting the signature. This works perfectly and is in my opinion a valid way of adding functionality that I would like without it being added to the main project if undesired (#560 ).However I am unable to do this as PestTestCommand is labeled final in the code.
Is it possible to remove the final label from the PestTestCommand? Is there a particular reason final is provided for this class?
I am happy to submit a PR if this is felt that it might be accepted.
Thank you.
Beta Was this translation helpful? Give feedback.
All reactions