Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t link to GND directly #57

Open
rettinghaus opened this issue Dec 15, 2019 · 3 comments
Open

Don’t link to GND directly #57

rettinghaus opened this issue Dec 15, 2019 · 3 comments

Comments

@rettinghaus
Copy link
Contributor

Names with references to the GND shouldn't link directly. Better would be a pop-over showing the normalized name from the GND with a separate link.
@rettinghaus
Copy link
Contributor Author

Basically fine now, but links from the Meta information modal do not work.
(Not complaining about my link, as I'm not present in the index, but Mattheson is.)

@pfefferniels pfefferniels reopened this May 19, 2020
@pfefferniels
Copy link
Owner

Oh – I will fix that. But anyways, do editors get an entry in the index?

@rettinghaus
Copy link
Contributor Author

Usually they don't (I think).

pfefferniels added a commit that referenced this issue May 20, 2020
@pfefferniels
git fit for new index of musical works, link to GND directly if it do…
dd2152d 
…esn't link to the index, see #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rettinghaus @pfefferniels