Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full SQL-gen tests #1509

Open
workingjubilee opened this issue Feb 1, 2024 · 2 comments
Open

Add full SQL-gen tests #1509

workingjubilee opened this issue Feb 1, 2024 · 2 comments
Labels
build-sys Regarding the "build system" of pgrx which is split between cargo-pgrx, pg-sys, and sql-entity-graph needs-test sql-gen test-support

Comments

@workingjubilee
Copy link
Member

We should have some snapshot tests of our SQL generation.

This might require caving and moving to ui_test instead of trybuild.
@workingjubilee workingjubilee added test-support sql-gen needs-test build-sys Regarding the "build system" of pgrx which is split between cargo-pgrx, pg-sys, and sql-entity-graph labels Feb 1, 2024
@workingjubilee workingjubilee mentioned this issue Feb 1, 2024
Open
@workingjubilee
Copy link
Member Author

Landing #1468 would make this much easier.

@workingjubilee
Copy link
Member Author

This bizarrely seems to be required before accepting the seemingly innocuous diff of #1521???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build-sys Regarding the "build system" of pgrx which is split between cargo-pgrx, pg-sys, and sql-entity-graph needs-test sql-gen test-support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@workingjubilee