Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely dismantle Actions-based tests except for combinatorics #1797

Open
workingjubilee opened this issue Aug 9, 2024 · 3 comments
Open

Comments

@workingjubilee
Copy link
Member

workingjubilee commented Aug 9, 2024

There are sets of tests that we have that should just be entered by a single command, like the tests for the individual "example extensions". They make fixing problems with them extremely slow because like fuck is anyone going to set up the actions runner on their desktop just to be able to run local testing, and thus everyone who contributes to pgrx, including myself, is averse to refactoring them.

related:

@workingjubilee
Copy link
Member Author

workingjubilee commented Aug 9, 2024

act exists but word on the block is it kinda sucks. I'm guessing it has the problem of not actually being the same as the runner. It doesn't even seem to fully support the GHA yamlscript.

@YohDeadfall
Copy link
Contributor

Have you considered the way bevy went? It allows to run the exactly same thing both in the CI and locally: https://github.com/bevyengine/bevy/tree/release-0.14.2/tools/ci.

@workingjubilee
Copy link
Member Author

@YohDeadfall That's basically my intention, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants