Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turnkey release + CI testing #1807

Open
workingjubilee opened this issue Aug 14, 2024 · 5 comments
Open

turnkey release + CI testing #1807

workingjubilee opened this issue Aug 14, 2024 · 5 comments

Comments

@workingjubilee
Copy link
Member

workingjubilee commented Aug 14, 2024

I spent some time on release engineering lately because I was tired of having to rejigger everything every time I cut a release:

The final objective here is to make the command for "test if the release can be run from this code" and "actually run the release" be essentially the same, and for it to simply be one wave of the wand.

@workingjubilee workingjubilee changed the title turnkey release + test the release code in CI turnkey release + CI testing Aug 14, 2024
@eeeebbbbrrrr
Copy link
Contributor

eeeebbbbrrrr commented Aug 14, 2024

The final objective here is to make the command for "test if the release can be run from this code" and "actually run the release" be essentially the same, and for it to simply be one wave of the wand.

What is the new command? Does release.md need an update or is it current?

@workingjubilee
Copy link
Member Author

It seems current except for finalize-release.sh not existing anymore.

@workingjubilee
Copy link
Member Author

workingjubilee commented Aug 14, 2024

I use a git workflow that requires my presence is confirmed every time git touches the network, so I'm not a huge fan of how prepare-release.sh currently works.

In particular this diff check doesn't work lol:

git fetch origin
git diff origin/develop | if [ "$0" = "" ]; then
    echo "git diff found local changes on develop branch, cannot cut release."
elif [ "$NEW_VERSION" = "" ]; then
    echo "No version set. Are you just copying and pasting this without checking?"
else
    git pull origin develop --ff-only

@workingjubilee
Copy link
Member Author

workingjubilee commented Aug 14, 2024

ah, it's the spaces, they break it. it should be

git diff origin/develop | if [ "$0"="" ]; then

and the condition should probably be inverted?

@workingjubilee
Copy link
Member Author

workingjubilee commented Aug 14, 2024

and this won't work on uncommitted / working directory changes, but we then git commit.

I wrote this code, too... 🙃 It needs to test against adding a file to the directory, etc. otherwise the script is kinda pointless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants