-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turnkey release + CI testing #1807
Comments
What is the new command? Does release.md need an update or is it current? |
It seems current except for finalize-release.sh not existing anymore. |
I use a git workflow that requires my presence is confirmed every time git touches the network, so I'm not a huge fan of how prepare-release.sh currently works. In particular this diff check doesn't work lol: git fetch origin
git diff origin/develop | if [ "$0" = "" ]; then
echo "git diff found local changes on develop branch, cannot cut release."
elif [ "$NEW_VERSION" = "" ]; then
echo "No version set. Are you just copying and pasting this without checking?"
else
git pull origin develop --ff-only |
ah, it's the spaces, they break it. it should be git diff origin/develop | if [ "$0"="" ]; then and the condition should probably be inverted? |
and this won't work on uncommitted / working directory changes, but we then I wrote this code, too... 🙃 It needs to test against adding a file to the directory, etc. otherwise the script is kinda pointless. |
I spent some time on release engineering lately because I was tired of having to rejigger everything every time I cut a release:
The final objective here is to make the command for "test if the release can be run from this code" and "actually run the release" be essentially the same, and for it to simply be one wave of the wand.
The text was updated successfully, but these errors were encountered: