xhprof segfaults php56

[hikmet]

Xhprof causes segfault on php56. We noticed there is an open bug here at https://bugs.php.net/bug.php?id=67997

thanks, --h.

[epriestley]

Can you try against HEAD? I think this was fixed by 55a47c0

[shanemeyers]

I compiled 91e0be9 from HEAD against PHP 5.6.0 and we still get a segfault when we have xhprof enabled. What kind of information do you need to help track this down?

[paulgao]

i have same segfault,can you fix it plz?

[paulgao]

maybe fix it.
plz see https://github.com/QafooLabs/xhprof/commit/16b3ae28b2558f99461325db4c4d3032db9e3746 .

[onethumb]

Any luck on this yet?

[paulgao]

i use QafooLabs/xhprof@16b3ae2 to patch.
not segfault more.

[FeepingCreature]

It's gone... :(

[onethumb]

@paulgao Do you still have that patch somewhere? Can you share it?

[onethumb]

@paulgao Also possible that's a private repo and we just can't see it... mind making it public or re-publishing somewhere public?

[paulgao]

oh, it renamed.
plz see QafooLabs/php-profiler-extension@16b3ae2 .

[bd808]

I can not reproduce the reported crash using 5.6.3 and the current HEAD (91e0be9).

[onethumb]

Crashes consistently for us on 5.6.3 with current HEAD (91e0be9). If we turn on XHPROF_FLAGS_NO_BUILTINS it no longer crashes.

[shanemeyers]

The crash still occurs for us using PHP 5.6.3 and HEAD (91e0be9). I tried using the QafooLabs/php-profiler-extension@16b3ae2 patch, but I couldn't get it to apply against HEAD.

[Xon]

Manually applying this pull request to HEAD (91e0be9) makes the crashes go away for me.

[beberlei]

You don't need to apply the patch from Qafoo PHP Profiler, just use that extension it is compatible with XHPROF: https://github.com/QafooLabs/php-profiler-extension.

Either compile from the repository using the installation hints in the README. Or we have Debian/Ubuntu packages and precompiled binaries for Linux and any PHP version 5.3 - 5.6:
https://qafoolabs.com/profiler/downloads

Its entirely usable without the SaaS platform we built around it, just use qafooprofiler_enable() and qafooprofiler_disable() instead.

[shanemeyers]

Applying pull #48 to HEAD (91e0be9) compiles cleanly, but we still get crashes.

 [Wed Jan 21 11:02:59 2015] [notice] child pid 25559 exit signal Segmentation fault (11)

[sn01615]

Sep 15 21:18:02 dev kernel: in php-fpm[400000+888000]
Sep 15 21:18:02 dev kernel: php-fpm[1982]: segfault at 0 ip 0000000000651d40 sp 00007ffe516d5380 error 6 in php-fpm[400000+888000]
Sep 15 21:18:02 dev kernel: php-fpm[2105]: segfault at 0 ip 0000000000651d40 sp 00007ffe516d5380 error 6 in php-fpm[400000+888000]

[xuanskyer]

kernel: php-fpm[51660]: segfault at 18 ip 00007f80e6f1c24f sp 00007fff264638e0 error 4 in xhprof.so[7f80e6f18000+6000]

try this: fix crash