Closes #2501-general-issue-make-subject-keys-flexible-in-all-functions #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs argument to use get_admiral_option("subject_keys"). Came across an issue during pkgdown checklist with bds_exposure.R lines 365-366 with !!!adsl_vars
…must've pulled by mistake.
Updated Functions and fixed an error when replacing UBSUBJID, STUDYID with get_admiral_options("Subject_keys)
…posure.Rmd line 365 but still get Argument `enexpr(analysis_var)` must be a <symbol>, but is missing.
…01-general-issue-make-subject-keys-flexible-in-all-functions
ProfessorP-beep
commented
Oct 1, 2024
ProfessorP-beep
changed the title
…ct_keys"), CMREFID = FAREFID) to address symbol expression error.
…umn and formatting
|
My fault, I just had to update Rtools, and finding where errors in the test scripts that used the updated functions was easier. |
bms63
reviewed
Oct 3, 2024
bundfussr
reviewed
Oct 8, 2024
Comment on lines
+15
to
+16
| - `derive_extreme_event()` was fixed such that `check_type = "none"` is accepted | ||
| again. (#2462) |
There was a problem hiding this comment.
This item shouldn't be moved to the upcoming release.
Comment on lines
+229
to
+232
| #' ~STUDYID, ~USUBJID, ~CMGRPID, ~CMREFID, ~CMDECOD, | ||
| #' "STUDY01", "BP40257-1001", "14", "1192056", "PARACETAMOL", | ||
| #' "STUDY01", "BP40257-1001", "18", "2007001", "SOLUMEDROL", | ||
| #' "STUDY01", "BP40257-1002", "19", "2791596", "SPIRONOLACTONE" |
There was a problem hiding this comment.
Could you align the columns?
Comment on lines
+235
to
+255
| #' ~STUDYID, ~USUBJID, ~FAGRPID, ~FAREFID, ~FATESTCD, ~FASTRESC, | ||
| #' "STUDY01", "BP40257-1001", "1", "1192056", "CMATC1CD", "N", | ||
| #' "STUDY01", "BP40257-1001", "1", "1192056", "CMATC2CD", "N02", | ||
| #' "STUDY01", "BP40257-1001", "1", "1192056", "CMATC3CD", "N02B", | ||
| #' "STUDY01", "BP40257-1001", "1", "1192056", "CMATC4CD", "N02BE", | ||
| #' "STUDY01", "BP40257-1001", "1", "2007001", "CMATC1CD", "D", | ||
| #' "STUDY01", "BP40257-1001", "1", "2007001", "CMATC2CD", "D10", | ||
| #' "STUDY01", "BP40257-1001", "1", "2007001", "CMATC3CD", "D10A", | ||
| #' "STUDY01", "BP40257-1001", "1", "2007001", "CMATC4CD", "D10AA", | ||
| #' "STUDY01", "BP40257-1001", "2", "2007001", "CMATC1CD", "D", | ||
| #' "STUDY01", "BP40257-1001", "2", "2007001", "CMATC2CD", "D07", | ||
| #' "STUDY01", "BP40257-1001", "2", "2007001", "CMATC3CD", "D07A", | ||
| #' "STUDY01", "BP40257-1001", "2", "2007001", "CMATC4CD", "D07AA", | ||
| #' "STUDY01", "BP40257-1001", "3", "2007001", "CMATC1CD", "H", | ||
| #' "STUDY01", "BP40257-1001", "3", "2007001", "CMATC2CD", "H02", | ||
| #' "STUDY01", "BP40257-1001", "3", "2007001", "CMATC3CD", "H02A", | ||
| #' "STUDY01", "BP40257-1001", "3", "2007001", "CMATC4CD", "H02AB", | ||
| #' "STUDY01", "BP40257-1002", "1", "2791596", "CMATC1CD", "C", | ||
| #' "STUDY01", "BP40257-1002", "1", "2791596", "CMATC2CD", "C03", | ||
| #' "STUDY01", "BP40257-1002", "1", "2791596", "CMATC3CD", "C03D", | ||
| #' "STUDY01", "BP40257-1002", "1", "2791596", "CMATC4CD", "C03DA" |
There was a problem hiding this comment.
Could you align the columns?
Comment on lines
+5
to
+9
| ~STUDYID, ~USUBJID, ~EXDOSFRQ, ~ASTDT, ~AENDT, | ||
| "STUDY01", "P01", "Q2D", ymd("2021-01-01"), ymd("2021-01-07"), | ||
| "STUDY01", "P01", "Q3D", ymd("2021-01-08"), ymd("2021-01-14"), | ||
| "STUDY01", "P01", "EVERY 2 WEEKS", ymd("2021-01-15"), ymd("2021-01-29"), | ||
| "STUDY01", "P02", "ONCE", ymd("2021-02-02"), ymd("2021-02-02") |
There was a problem hiding this comment.
Could you align the columns?
Comment on lines
+12
to
+22
| ~STUDYID, ~USUBJID, ~EXDOSFRQ, ~ASTDT, ~AENDT, | ||
| "STUDY01", "P01", "ONCE", ymd("2021-01-01"), ymd("2021-01-01"), | ||
| "STUDY01", "P01", "ONCE", ymd("2021-01-03"), ymd("2021-01-03"), | ||
| "STUDY01", "P01", "ONCE", ymd("2021-01-05"), ymd("2021-01-05"), | ||
| "STUDY01", "P01", "ONCE", ymd("2021-01-07"), ymd("2021-01-07"), | ||
| "STUDY01", "P01", "ONCE", ymd("2021-01-08"), ymd("2021-01-08"), | ||
| "STUDY01", "P01", "ONCE", ymd("2021-01-11"), ymd("2021-01-11"), | ||
| "STUDY01", "P01", "ONCE", ymd("2021-01-14"), ymd("2021-01-14"), | ||
| "STUDY01", "P01", "ONCE", ymd("2021-01-15"), ymd("2021-01-15"), | ||
| "STUDY01", "P01", "ONCE", ymd("2021-01-29"), ymd("2021-01-29"), | ||
| "STUDY01", "P02", "ONCE", ymd("2021-02-02"), ymd("2021-02-02") |
There was a problem hiding this comment.
Could you align the columns?
| "P01", 3, | ||
| "P02", 31, | ||
| "P03", 42 | ||
| ~STUDYID, ~USUBJID, ~VAR1, |
There was a problem hiding this comment.
Could you align the columns (here and below)?
| @@ -361,7 +361,7 @@ For example, to calculate the total dose by subject and treatment, | |||
| adex <- derive_param_exposure( | |||
| adex, | |||
| dataset_add = adex, | |||
| by_vars = exprs(STUDYID, USUBJID, !!!adsl_vars), | |||
| by_vars = c(get_admiral_option("subject_keys"), adsl_vars), | |||
There was a problem hiding this comment.
Either we should update all calls in the vignette or none.
@bms63 , did we reach a decision regarding updating vignettes and templates?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task.styler::style_file()to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptxand re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)devtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdunder the header# admiral (development version)if the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.mdfor tracking developer-facing issues.pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()