Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find libgit2 in LD_LIBRARY_PATH #441

Open
lukego opened this issue Aug 20, 2017 · 0 comments
Open

Find libgit2 in LD_LIBRARY_PATH #441

lukego opened this issue Aug 20, 2017 · 0 comments

Comments

@lukego
Copy link

lukego commented Aug 20, 2017

It would be wonderful if Iceberg could find libgit2 in LD_LIBRARY_PATH. This would be helpful for people who are building custom VMs that do not follow the same filesystem layout at the pharo.org one.

Pharo is already able to search LD_LIBRARY_PATH but this is being inhibited by an extra check that is specific to Iceberg:

screenshot 2017-08-20 20 57 03

This method is trying to detect whether to look for libgit2.so or libgit2.so.0 but if it cannot decide then it raises an error. I propose that instead of raising an error it could simply return ^ 'libgit2.so' as a default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants