Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce patch #730

Open
guillep opened this issue Apr 28, 2018 · 0 comments
Open

Introduce patch #730

guillep opened this issue Apr 28, 2018 · 0 comments

Comments

@guillep
Copy link
Member

guillep commented Apr 28, 2018

Right not the application of changes (and thus also reverts) is a bit of a mess:

  • part of it depends on monticello loading
  • part of it is in visitors

Monticello loading is nice because it sorts the changes and applies them in the right order.
However, by default monticello does that in a per-package basis.

We need to do it in a per-repository basis. Otherwise inter-dependent changes from different packages in the same repository may be loaded in the wrong order and raise uncomfortable load warnings.

This could be solved by introducing a repository patch abstraction on iceberg. Visitors should then only build a patch and the patch be installed in a single-shot. Maybe monticello's patch/loader could be reused?

@guillep guillep added this to the 0.7.5 milestone Apr 28, 2018
@guillep guillep modified the milestones: 0.7.5, 0.7.6 May 3, 2018
@guillep guillep removed this from the 1.0.0 milestone May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant