Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

Enable Gin's high contrast mode to improve accessibility #147

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

thegbomb
Copy link
Contributor

Problem/Motivation

The accessibility of the gin admin theme can be improved by enabling its high contrast option.

Proposed resolution

Enable the high contrast mode.

simple_config_update:
high_contrast_mode: true
accent_color: ''
focus_color: ''
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question - why are the accent and focus colors removed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They aren't set until the high contrast is enabled, when the setting is switched on, those values are set to an empty string and could be changed if necessary, the defaults are an improvement as they are, but I will consult others to see if a better setting could be used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bizarrely, I double-checked where this came from by installing starshot and exporting the config.

I then switched on the high contrast toggle and exported again to see the diff. The accent and focus colours were not in the original export, but are added when the high contrast is switched on. There are other changes, but mostly just moving config up and down in the config file. I'll remove them as they seem to be set not changed.

@phenaproxima phenaproxima changed the title Adding high contrast to gin config to improve a11y. Enable Gin's high contrast mode to improve accessibility Jul 27, 2024
@phenaproxima phenaproxima merged commit d515ec6 into phenaproxima:main Jul 27, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants